Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish --dry-run validate more Cargo.toml keys #14641

Closed
jordy25519 opened this issue Oct 4, 2024 · 1 comment
Closed

publish --dry-run validate more Cargo.toml keys #14641

jordy25519 opened this issue Oct 4, 2024 · 1 comment
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-triage Status: This issue is waiting on initial triage.

Comments

@jordy25519
Copy link

Problem

some validations failing after passing --dry-run:

  • keywords max limit is 5
  • categories must be from a subset supported slugs

I assumed --dry-run success meant validation passes and the crate will upload successfully

painful to rerun build several times to encounter these

Proposed Solution

  • hard lints/error for keywords count > 5 in --dry-run mode
  • validate categories from subset of known slugs or network request to update the list

Notes

cargo 1.81.0 (2dbb1af80 2024-08-20)

@jordy25519 jordy25519 added C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-triage Status: This issue is waiting on initial triage. labels Oct 4, 2024
@weihanglo
Copy link
Member

Hi! Thank you for the report! This seems to be a duplicate of #2098, #3662, #4300, #4377, #14249, #14426. Among them, #4377 is the main tracking issue of it, so closing in favor of that.

Note that the limitations are set by a single registry (crates.io), while Cargo needs to support different registries.

@weihanglo weihanglo closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-triage Status: This issue is waiting on initial triage.
Projects
None yet
Development

No branches or pull requests

2 participants