Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary index fetching upon patching two dependencies with same package name #13862

Closed
ldm0 opened this issue May 4, 2024 · 3 comments
Closed

Unnecessary index fetching upon patching two dependencies with same package name #13862

ldm0 opened this issue May 4, 2024 · 3 comments
Labels
A-dependency-resolution Area: dependency resolution and the resolver A-lockfile Area: Cargo.lock issues C-bug Category: bug S-triage Status: This issue is waiting on initial triage.

Comments

@ldm0
Copy link

ldm0 commented May 4, 2024

Problem

If you have two patches on two dependencies with same package name, you will see Updating crates.io index every time you run cargo check. The index update is unnecessary and slows down development speed.

Steps

Simple reproduction repo:
https://github.com/ldm0/cargo-bug-repo/tree/31fb297e58ffa3be877062940a300883d2cb580a

  1. Run cargo check
  2. Run cargo check (you will still see Updating crates.io index)

Possible Solution(s)

I'll file a fix PR later.

Notes

No response

Version

Can't find a cargo version which doesn't have this issue.
@ldm0 ldm0 added C-bug Category: bug S-triage Status: This issue is waiting on initial triage. labels May 4, 2024
@ldm0 ldm0 mentioned this issue May 4, 2024
Closed
@epage epage added A-dependency-resolution Area: dependency resolution and the resolver A-lockfile Area: Cargo.lock issues labels May 6, 2024
@epage
Copy link
Contributor

epage commented May 6, 2024

Sounds like this is a duplicate of #13405. Is that right?

@ldm0
Copy link
Author

ldm0 commented May 6, 2024

Yeah, the root cause is the same. Bug behaviour differs though.

@weihanglo
Copy link
Member

Since #13572 is merged, I'll go ahead and close this as resolved. Let us know if things are still wrong. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependency-resolution Area: dependency resolution and the resolver A-lockfile Area: Cargo.lock issues C-bug Category: bug S-triage Status: This issue is waiting on initial triage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't squash path dependencies with same package name ldm0/cargo
3 participants
@epage @weihanglo @ldm0