Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 4.1 - consider change to punctuation to make sentence clearer #2412

Closed
hughrun opened this issue Jul 30, 2020 · 1 comment · Fixed by #2419
Closed

Chapter 4.1 - consider change to punctuation to make sentence clearer #2412

hughrun opened this issue Jul 30, 2020 · 1 comment · Fixed by #2419

Comments

@hughrun
Copy link
Contributor

hughrun commented Jul 30, 2020

There is potentially confusing punctuation in this section of Chapter 4.1:

Stack-Only Data: Copy

There’s another wrinkle we haven’t talked about yet. This code using integers, part of which was 
shown in Listing 4-2, works and is valid:

On my initial read this looked like a typo which should have read This code is using integers...

I suggest replacing the commas with dashes to make the sentence clearer:

This code using integers – part of which was shown in Listing 4-2 – works and is valid:
@steveklabnik
Copy link
Member

Sure, I would happily take a PR that uses an em dash here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants