This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
fix for backtrace 0.3.10 #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why CI still fails, this PR now does not touch the lockfile? |
|
I thought it might have been a cache thing but it wasn't. @alexcrichton looks like backtrace doesn't work on Rust 1.18 any more, which breaks failure's CI. |
|
Closing in favor of #279, which was first. |
BurntSushi
reviewed
Dec 11, 2018
| } else { Ok(()) } | ||
| } | ||
| } | ||
|
|
||
| impl Display for Backtrace { | ||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| if let Some(bt) = self.internal.as_backtrace() { | ||
| bt.fmt(f) | ||
| Debug::fmt(bt, f) |
There was a problem hiding this comment.
@RalfJung I think this should be Display.
There was a problem hiding this comment.
That would require bumping the minimal version of backtrace, though.
And anyway I closed this PR because #279 does the same thing.
There was a problem hiding this comment.
Right, yeah, I was trying to answer: #279 (comment)
But I didn't know about the minimal version requirement.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a
Displayinstance now, sobt.fmtis ambiguous.Cc rust-lang/rust#56718