Revert target directory cleanup #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit 9bdc4e8 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 3, 2019
Revert target directory cleanup Actually broke a lot of stuff.
|
☀️ Test successful - checks-travis, status-appveyor |
|
As I recall it worked but was not worth the time. What did it brake? |
|
https://crater-reports.s3.amazonaws.com/maint-2018-12-30-2/full.html 45k crates errored out, and looking at the logs it's probably a coding error on my side I didn't catch while testing the PR locally. |
|
To clarify, that shouldn't be an issue with the concept of downloading those files, but more of an implementation bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually broke a lot of stuff.