From a4ffeb026326cf61b24589df742c2b1eb372b7e2 Mon Sep 17 00:00:00 2001 From: Juniper Tyree <50025784+juntyr@users.noreply.github.com> Date: Fri, 18 Oct 2024 10:02:28 +0300 Subject: [PATCH 1/3] Add WASM | WASI | Emscripten groups to triagebot.toml --- triagebot.toml | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/triagebot.toml b/triagebot.toml index 33dcbfa55a4f2..c033fb7f39f64 100644 --- a/triagebot.toml +++ b/triagebot.toml @@ -135,6 +135,43 @@ In case it's useful, here are some [instructions] for tackling these sorts of is """ label = "O-rfl" +[ping.wasm] +alias = ["webassembly"] +message = """\ +Hey WASM notification group! This issue or PR could use some WebAssembly-specific +guidance. Could one of you weigh in? Thanks <3 + +(In case it's useful, here are some [instructions] for tackling these sorts of +issues). + +[instructions]: https://rustc-dev-guide.rust-lang.org/notification-groups/wasm.html +""" +label = "O-wasm" + +[ping.wasi] +message = """\ +Hey WASI notification group! This issue or PR could use some WASI-specific guidance. +Could one of you weigh in? Thanks <3 + +(In case it's useful, here are some [instructions] for tackling these sorts of +issues). + +[instructions]: https://rustc-dev-guide.rust-lang.org/notification-groups/wasi.html +""" +label = "O-wasi" + +[ping.emscripten] +message = """\ +Hey Emscripten notification group! This issue or PR could use some Emscripten-specific +guidance. Could one of you weigh in? Thanks <3 + +(In case it's useful, here are some [instructions] for tackling these sorts of +issues). + +[instructions]: https://rustc-dev-guide.rust-lang.org/notification-groups/emscripten.html +""" +label = "O-emscripten" + [prioritize] label = "I-prioritize" From c18bab3fe64c8786c26ac483dac13f615e544276 Mon Sep 17 00:00:00 2001 From: David Ross Date: Mon, 21 Oct 2024 20:05:55 -0700 Subject: [PATCH 2/3] Document PartialEq impl for OnceLock --- library/std/src/sync/once_lock.rs | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/library/std/src/sync/once_lock.rs b/library/std/src/sync/once_lock.rs index be615a5a8ef37..0ae3cf4df3614 100644 --- a/library/std/src/sync/once_lock.rs +++ b/library/std/src/sync/once_lock.rs @@ -634,6 +634,26 @@ impl From for OnceLock { #[stable(feature = "once_cell", since = "1.70.0")] impl PartialEq for OnceLock { + /// Equality for two `OnceLock`s. + /// + /// Two `OnceLock`s are equal if they either both contain values and their + /// values are equal, or if neither contains a value. + /// + /// # Examples + /// + /// ``` + /// use std::sync::OnceLock; + /// + /// let five = OnceLock::new(); + /// five.set(5).unwrap(); + /// + /// let also_five = OnceLock::new(); + /// also_five.set(5).unwrap(); + /// + /// assert!(five == also_five); + /// + /// assert!(OnceLock::::new() == OnceLock::::new()); + /// ``` #[inline] fn eq(&self, other: &OnceLock) -> bool { self.get() == other.get() From 5f4739157abe8ac9ba3bbc652f6d7893d2a4d4c9 Mon Sep 17 00:00:00 2001 From: Jieyou Xu Date: Sat, 26 Oct 2024 13:07:26 +0000 Subject: [PATCH 3/3] Downgrade `untranslatable_diagnostic` and `diagnostic_outside_of_impl` to `allow` See for more context. --- compiler/rustc_lint/src/internal.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/compiler/rustc_lint/src/internal.rs b/compiler/rustc_lint/src/internal.rs index 94cc58e495681..71f6214d880c8 100644 --- a/compiler/rustc_lint/src/internal.rs +++ b/compiler/rustc_lint/src/internal.rs @@ -427,7 +427,7 @@ declare_tool_lint! { /// More details on translatable diagnostics can be found /// [here](https://rustc-dev-guide.rust-lang.org/diagnostics/translation.html). pub rustc::UNTRANSLATABLE_DIAGNOSTIC, - Deny, + Allow, "prevent creation of diagnostics which cannot be translated", report_in_external_macro: true } @@ -440,7 +440,7 @@ declare_tool_lint! { /// More details on diagnostics implementations can be found /// [here](https://rustc-dev-guide.rust-lang.org/diagnostics/diagnostic-structs.html). pub rustc::DIAGNOSTIC_OUTSIDE_OF_IMPL, - Deny, + Allow, "prevent diagnostic creation outside of `Diagnostic`/`Subdiagnostic`/`LintDiagnostic` impls", report_in_external_macro: true }