Newsletter 13: A little section about rspirv-reflect #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The general content of this PR looks good, but according to the tracking issue it's generally preferred to write in third person (i.e "Traverse Research have created rspirv-reflect"), to keep a consistent tone between sections. Could you tweak this to match that guideline? Happy to approve this other than that one little nitpick :)
|
Thanks for the feedback @17cupsofcoffee, does conform to the guidelines better? |
17cupsofcoffee
approved these changes
Sep 2, 2020
|  | ||
|
|
||
| [Traverse Research] has created the [rspirv-reflect] library to replace | ||
| our very basic use-case of the existing [spirv-reflect-rs] / [spirv-reflect] |
There was a problem hiding this comment.
Suggested change
| our very basic use-case of the existing [spirv-reflect-rs] / [spirv-reflect] | |
| their very basic use-case of the existing [spirv-reflect-rs] / [spirv-reflect] |
| of writing) and it also supports all the new shader stages (both ray tracing | ||
| and mesh/task shaders) as well as the existing ones. | ||
|
|
||
| Traverse Research wanted to reduce their reliance on C and C++ unsafe |
There was a problem hiding this comment.
Suggested change
| Traverse Research wanted to reduce their reliance on C and C++ unsafe | |
| Traverse Research wanted to reduce their reliance on C and C++ unsafe |
| and mesh/task shaders) as well as the existing ones. | ||
|
|
||
| Traverse Research wanted to reduce their reliance on C and C++ unsafe | ||
| libraries and at the same time we needed to support newer features that were |
There was a problem hiding this comment.
Suggested change
| libraries and at the same time we needed to support newer features that were | |
| libraries and at the same time we needed to support newer features that were |
|
|
||
| Traverse Research wanted to reduce their reliance on C and C++ unsafe | ||
| libraries and at the same time we needed to support newer features that were | ||
| slow to become available in the existing `spirv-reflect` library. The primary |
There was a problem hiding this comment.
Suggested change
| slow to become available in the existing `spirv-reflect` library. The primary | |
| slow to become available in the existing `spirv-reflect` library. The primary |
| Traverse Research wanted to reduce their reliance on C and C++ unsafe | ||
| libraries and at the same time we needed to support newer features that were | ||
| slow to become available in the existing `spirv-reflect` library. The primary | ||
| use-case for this library is in conjecture with the Rust wrapper around the |
There was a problem hiding this comment.
Suggested change
| use-case for this library is in conjecture with the Rust wrapper around the | |
| use-case for this library is in conjecture with the Rust wrapper around the |
| libraries and at the same time we needed to support newer features that were | ||
| slow to become available in the existing `spirv-reflect` library. The primary | ||
| use-case for this library is in conjecture with the Rust wrapper around the | ||
| DirectX Shader Compiler ([dxc]), called [hassle-rs] that Traverse Research |
There was a problem hiding this comment.
Suggested change
| DirectX Shader Compiler ([dxc]), called [hassle-rs] that Traverse Research | |
| DirectX Shader Compiler ([dxc]), called [hassle-rs] that Traverse Research |
|
Thanks for the PR! Merged manually (a68fb5f) as I don't have write permission to the PR's branch. |
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #232, I wrote a small section on rspirv-reflect.