fix #74 #306

spookyvision · 2021-01-25T21:26:09Z

special-cased linker section names to satisfy macos linker constraints

rust-highfive · 2021-01-25T21:26:12Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonas-schievink (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

jonas-schievink · 2021-01-26T00:16:12Z

If you rebase this on current master CI should pass. We should also add a new job here that just build without --target, since that should work after this PR:

cortex-m-rt/.github/workflows/ci.yml

Line 80 in 89bdd8c

run: cargo build --target=thumbv8m.main-none-eabihf --examples

spookyvision · 2021-01-26T15:18:23Z

If you rebase this on current master CI should pass.

unfortunately not, still getting language item required, but not found: 'eh_personality' for cargo build --examples. Adding panic = "abort" to [profile.dev] made this go away (and unearthed another broken link section name, which I've fixed with another commit in the meantime), but this is probably not the right way to go ahead?

with the temporary fix for eh_personality, remaining errors are:

error: linking with `cc` failed: exit code: 1
  |
  = note: "cc" "-m64" "-arch" "x86_64" "-L" "/Users/anatol.ulrich/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/examples/pre_init.41pb4842pbk6h8fj.rcgu.o" "-o" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/examples/pre_init" "-Wl,-dead_strip" "-nodefaultlibs" "-L" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps" "-L" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/build/cortex-m-rt-16e34855d1ab5756/out" "-L" "/Users/anatol.ulrich/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps/libpanic_halt-fa926b5489e34768.rlib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps/libcortex_m_rt-9ecd0db86bd21c1b.rlib" "/Users/anatol.ulrich/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/librustc_std_workspace_core-99bca6ace58141c5.rlib" "/Users/anatol.ulrich/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libcore-72a66f4c97a4c0c8.rlib" "/Users/anatol.ulrich/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libcompiler_builtins-e7cd9f0beed2fc0f.rlib"
  = note: ld: dynamic main executables must link with libSystem.dylib for architecture x86_64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

(several occurrences)

and

error: linking with `cc` failed: exit code: 1
  |
  = note: "cc" "-m64" "-arch" "x86_64" "-L" "/Users/anatol.ulrich/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/examples/qemu.131k0j0eiyyppm1j.rcgu.o" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/examples/qemu.1856riucyqnr98i3.rcgu.o" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/examples/qemu.1kfksmat7ftapeni.rcgu.o" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/examples/qemu.2665blsxk9zbeyyd.rcgu.o" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/examples/qemu.2jskah2k0tfezcd0.rcgu.o" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/examples/qemu.3kpzafbr7npkpxbu.rcgu.o" "-o" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/examples/qemu" "-Wl,-dead_strip" "-nodefaultlibs" "-L" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps" "-L" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/build/cortex-m-rt-16e34855d1ab5756/out" "-L" "/Users/anatol.ulrich/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps/libpanic_halt-fa926b5489e34768.rlib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps/libcortex_m_semihosting-3fdbe42e3865b53f.rlib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps/libcortex_m_rt-9ecd0db86bd21c1b.rlib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps/libcortex_m-31c5941f301e80db.rlib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps/libembedded_hal-c1582eeb3909021d.rlib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps/libvoid-da898260d610f50d.rlib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps/libnb-8d47a613bc85f978.rlib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps/libnb-4367aac38fcdfd15.rlib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps/libvolatile_register-a6bee15977cbed10.rlib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps/libvcell-d9c3ff73f19dce6e.rlib" "/Users/anatol.ulrich/work/cortex-m-rt/target/debug/deps/libbare_metal-130812a6caf1a5da.rlib" "/Users/anatol.ulrich/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/librustc_std_workspace_core-99bca6ace58141c5.rlib" "/Users/anatol.ulrich/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libcore-72a66f4c97a4c0c8.rlib" "/Users/anatol.ulrich/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libcompiler_builtins-e7cd9f0beed2fc0f.rlib"
  = note: Undefined symbols for architecture x86_64:
            "_memcpy", referenced from:
                core::fmt::Write::write_fmt::h2ba7f7f38cfa5045 in libcortex_m_semihosting-3fdbe42e3865b53f.rlib(cortex_m_semihosting-3fdbe42e3865b53f.cortex_m_semihosting.2d5joapa-cgu.0.rcgu.o)
                _$LT$$RF$mut$u20$W$u20$as$u20$core..fmt..Write$GT$::write_fmt::h5c55410df270d15d in libcortex_m_semihosting-3fdbe42e3865b53f.rlib(cortex_m_semihosting-3fdbe42e3865b53f.cortex_m_semihosting.2d5joapa-cgu.0.rcgu.o)
            "_memset", referenced from:
                core::fmt::Write::write_char::hc0a51b72bc1ae45b in libcortex_m_semihosting-3fdbe42e3865b53f.rlib(cortex_m_semihosting-3fdbe42e3865b53f.cortex_m_semihosting.2d5joapa-cgu.0.rcgu.o)
            "___nop", referenced from:
                cortex_m::asm::nop::h74dc3ed233ca0d95 in qemu.2665blsxk9zbeyyd.rcgu.o
          ld: symbol(s) not found for architecture x86_64
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

jonas-schievink · 2021-01-26T15:30:18Z

Oh, the examples won't build even on Linux. We should only test that the main cortex-m-rt crate builds (not links).

jonas-schievink

bors r+

bors · 2021-01-26T16:30:58Z

Build succeeded:

310: Only emit link_section for cortex-m r=jonas-schievink a=adamgreig Previously we always emitted `link_section`, even though it only had an effect when our linker script was being used (and only made sense on cortex-m targets). This breaks building the code for a MacOS target, which is occasionally useful for running `cargo check` etc. In the macros crate we don't have the target information available, so instead we continue to emit `link_section` except specifically on MacOS. This keeps the fix from #306 but hopefully resolves the confusion in #74 (comment). Co-authored-by: Adam Greig <adam@adamgreig.com>

fix rust-embedded#74

4bbee87

spookyvision requested a review from a team as a code owner January 25, 2021 21:26

rust-highfive assigned jonas-schievink Jan 25, 2021

rust-highfive added S-waiting-on-review T-cortex-m labels Jan 25, 2021

Anatol Ulrich added 2 commits January 26, 2021 16:09

Merge branch 'master' of ssh://github.com/rust-embedded/cortex-m-rt

aebafdf

fix .HardFault.user section name for macos

2a7542b

add host build test; rename "crate" to "examples" in others to clarify

8e38302

jonas-schievink approved these changes Jan 26, 2021

View reviewed changes

bors bot merged commit 4aee094 into rust-embedded:master Jan 26, 2021

spookyvision mentioned this pull request Jan 26, 2021

simplify CI: remove macos special case knurling-rs/defmt#358

Closed

adamgreig mentioned this pull request Jan 27, 2021

Only emit link_section for cortex-m #310

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix #74 #306

fix #74 #306

spookyvision commented Jan 25, 2021

rust-highfive commented Jan 25, 2021

jonas-schievink commented Jan 26, 2021

spookyvision commented Jan 26, 2021 •

edited

Loading

jonas-schievink commented Jan 26, 2021

jonas-schievink left a comment

bors bot commented Jan 26, 2021

fix #74 #306

fix #74 #306

Conversation

spookyvision commented Jan 25, 2021

rust-highfive commented Jan 25, 2021

jonas-schievink commented Jan 26, 2021

spookyvision commented Jan 26, 2021 • edited Loading

jonas-schievink commented Jan 26, 2021

jonas-schievink left a comment

Choose a reason for hiding this comment

bors bot commented Jan 26, 2021

spookyvision commented Jan 26, 2021 •

edited

Loading