Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the project maintained? #159

Closed
Veetaha opened this issue May 21, 2020 · 27 comments
Closed

Is the project maintained? #159

Veetaha opened this issue May 21, 2020 · 27 comments

Comments

@Veetaha
Copy link

Veetaha commented May 21, 2020

@sebasmagri might I ask you whether you are still interested in maintaining this crate and if you'd like to pass the maintenance to anyone else?

@Veetaha
Copy link
Author

Veetaha commented May 21, 2020

cc @KodrAus

@sebasmagri
Copy link
Collaborator

For a long time @KodrAus has been the main maintainer of the project. So actually I'd be fine passing the maintenance/ownership of the project to him or someone he agrees on.

@jplatte
Copy link
Contributor

jplatte commented Jul 1, 2020

This crate is pretty popular, I am surprised it is hardly maintained :/

@KodrAus is this on your todo list?

@KodrAus
Copy link
Collaborator

KodrAus commented Jul 1, 2020

It is on my todo list (along with bitflagsand uuid). Unfortunately it’s been a really big year and it hasn’t managed to find its way to the top yet. I’d be up for creating a env_logger_rs org on GitHub and moving the project into it so it’s easy to add contributors and people with publish rights.

If I create the org would you be happy to migrate @sebasmagri?

@KodrAus
Copy link
Collaborator

KodrAus commented Jul 1, 2020

In the meantime I'll do a pass through all the open PRs 👀

@sebasmagri
Copy link
Collaborator

Yes absolutely @KodrAus! 100% up to make it easier to onboard new collaborators.

@mainrs
Copy link
Contributor

mainrs commented Jul 10, 2020

If you guys need help on PRs and issue management, I can help out :) I do already do this for a lot of Rust projects (the biggest one being spotifyd).

@KodrAus
Copy link
Collaborator

KodrAus commented Jul 12, 2020

@sebasmagri @sirwindfield I've created an env-logger-rs repository and invited you both to it 🙂 I've opened #163 to track our progress migrating the repository into that org

@mainrs
Copy link
Contributor

mainrs commented Jul 12, 2020

Awesome! Thank you!

@KodrAus
Copy link
Collaborator

KodrAus commented Jul 12, 2020

@sebasmagri I think you’re the only one who’s got permission to move the repository 🙂

@kornelski
Copy link

The last release has been almost a year ago. It'd be nice to release latest changes.

@mainrs
Copy link
Contributor

mainrs commented Sep 2, 2020

We don't have publishing rights, they haven't been granted to us. @kornelski

@kornelski
Copy link

:(

@alexcrichton @sfackler and @huonw also have crates-io ownership. Maybe they can help?

@mainrs
Copy link
Contributor

mainrs commented Sep 2, 2020

If they wouldn't mind. We wanted to have the whole publisher team have access to publishing, so they'd have to run this command:

cargo owner --add github:env-logger-rs:publishers

@sebasmagri
Copy link
Collaborator

sebasmagri commented Sep 2, 2020

I tried last time and crates.io gave me some error. Will try again.

Edit:

It's still giving me some issues:

error: failed to invite owners to crate env_logger: api errors (status 200 OK): could not find the github team env-logger-rs/publishers

@sirwindfield I just checked the team and it seems to be fine. Any ideas here?

@mainrs
Copy link
Contributor

mainrs commented Sep 2, 2020

No clue. But I can figure it out. You could add me for now. That way I can see what is wrong there and try to add the team myself. @sebasmagri

@kornelski
Copy link

kornelski commented Sep 2, 2020

I think github has privacy controls around team's existence and membership. You may need to log in to crates-io again and grant it access to the env-logger-rs org, so that it can scan its teams.

@mainrs
Copy link
Contributor

mainrs commented Sep 2, 2020

@kornelski Ah! Did re-log and granted crates.io access to @env-logger-rs. At least crates.io is listed under authorized apps now :)

@sebasmagri
Copy link
Collaborator

That apparently did it! Thanks @kornelski

@Veetaha
Copy link
Author

Veetaha commented Sep 2, 2020

I'd just recommend adding publishing to CI like this

This makes the process of publishing more automated (you just push a new git tag), and more transparent (the publisher won't inject malicious code before publishing the crate).

@jplatte
Copy link
Contributor

jplatte commented Sep 14, 2020

The maintenance issues have been addressed. I'm personally not sure what to think of the CI publishing suggestion, but in any case that seems like it should be a separate issue.

@jplatte jplatte closed this as completed Sep 14, 2020
@jplatte
Copy link
Contributor

jplatte commented Jun 20, 2022

This project has once again run out of (active) maintainers, it seems. I'm no longer using env_logger so while I'm definitely still very active in the Rust community overall, it's hard to justify spending time on this.

@jplatte jplatte reopened this Jun 20, 2022
@Veetaha
Copy link
Author

Veetaha commented Jun 20, 2022

@jplatte are you using tracing now? I think log gets pushed back more and more by tracing, thus that's understandable

@jplatte
Copy link
Contributor

jplatte commented Jun 21, 2022

Yes, I've been exclusively using tracing(-subscriber) instead of log / env_logger for quite a while now.

@epage
Copy link
Contributor

epage commented Nov 4, 2022

@jplatte One option: the CLI-WG helps "keep the lights on" for important CLI-related crates. I think this one counts if you are up for adding us as maintainers.

@jplatte
Copy link
Contributor

jplatte commented Nov 5, 2022

@epage that's great, I've added you as an org owner. Please do kick me out of the org once you have confirmed that everything works and add other people, or just move the repo to another org like rust-lang-nursery if that makes sense to you. The list of people who can publish this crate on crates.io is very long and it probably makes sense to cut it down a bit to those who are actually somewhat likely to be involved with the project in the future.

@jplatte
Copy link
Contributor

jplatte commented Nov 7, 2022

Not sure why epage didn't do it yet, but I'm now removing myself from the org after having released v0.9.2. I think this can be closed again.

@jplatte jplatte closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants