Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should also probably make AlignedType contain MaybeUninit or something like that, as the C code might write padding bytes to it. #707

Open
apoelstra opened this issue Jul 6, 2024 · 3 comments
Open

We should also probably make AlignedType contain MaybeUninit or something like that, as the C code might write padding bytes to it. #707

apoelstra opened this issue Jul 6, 2024 · 3 comments

Comments

@apoelstra
Copy link
Member 

          We should also probably make `AlignedType` contain `MaybeUninit` or something like that, as the C code might write padding bytes to it.

I think it wasn't stable (enough) back when I implemented this logic

Originally posted by @elichai in #635 (comment)
@apoelstra apoelstra mentioned this issue Jul 6, 2024
Draft
@Kixunil
Copy link
Collaborator

Kixunil commented Jul 6, 2024

Indeed, MaybeUninit was stabilized quite late relative to both rust-bitcoin birth and my involvement in Rust.

@tcharding
Copy link
Member

This weeks candidate for worst issue title ever :)

@apoelstra
Copy link
Member Author

Yeah, sorry, normally I shorten the result of "reference in new issue" but I got lazy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kixunil @apoelstra @tcharding