Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use std without rand dependency #150

Closed
str4d opened this issue Aug 16, 2019 · 3 comments
Closed

Cannot use std without rand dependency #150

str4d opened this issue Aug 16, 2019 · 3 comments

Comments

@str4d
Copy link

str4d commented Aug 16, 2019

#136 added rand/std to the std feature. This change forces rand to be in the dependency tree when std is enabled, even if the rand feature is disabled. This makes it impossible to use secp256k1 with std but without rand in the dependency tree.

@elichai
Copy link
Member

elichai commented Aug 16, 2019

Hmm that's not good.

I'm not sure what solutions rust offer. we might need to default rand to include std and if you want rand you must get std.
Or have a separate rand-std feature :/

@apoelstra
Copy link
Member

Frustrating. rust-lang/cargo#3494

I think a separate rand-std feature is the best option.

@elichai
Copy link
Member

elichai commented Jan 9, 2020

Can we close? #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants