Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support auto-closing for triple backticks #17051

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

roife
Copy link
Member

@roife roife commented Apr 11, 2024

It might fix #16051, see #16051 (comment)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 11, 2024
@roife
Copy link
Member Author

roife commented Apr 11, 2024

If auto-closing for backticks only works in comments, that would be even better.

Perhaps we can submit a related API (something like onlyIn) to VS Code. 🤔

@Veykril
Copy link
Member

Veykril commented Apr 13, 2024

Sounds reasonable! Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Apr 13, 2024

📌 Commit 4346bbc has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 13, 2024

⌛ Testing commit 4346bbc with merge e1d7ce7...

@bors
Copy link
Collaborator

bors commented Apr 13, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e1d7ce7 to master...

@bors bors merged commit e1d7ce7 into rust-lang:master Apr 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-closing backticks does not work well combined with triple backtick code blocks.
4 participants