Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: limit struct hover display nums #16906

Merged
merged 5 commits into from
Mar 25, 2024
Merged

feat: limit struct hover display nums #16906

merged 5 commits into from
Mar 25, 2024

Conversation

Young-Flash
Copy link
Member

follow up #15847, #15938

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 21, 2024
@Young-Flash Young-Flash changed the title feat; limit struct hover display nums feat: limit struct hover display nums Mar 21, 2024
Veykril
Veykril reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And a test with the config set Some would be good

crates/hir/src/display.rs Outdated Show resolved Hide resolved
@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2024
@Young-Flash Young-Flash force-pushed the limit_struct_hover_display branch from 063c8ab to 58013ad Compare March 25, 2024 11:55
@Veykril
Copy link
Member

Veykril commented Mar 25, 2024 •
edited
Loading

Thanks!
@bors r+

@Veykril
Copy link
Member

Veykril commented Mar 25, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 25, 2024

📌 Commit 58013ad has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 25, 2024

⌛ Testing commit 58013ad with merge e52bb8c...

@bors
Copy link
Contributor

bors commented Mar 25, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e52bb8c to master...

@bors bors merged commit e52bb8c into rust-lang:master Mar 25, 2024
11 checks passed
@bors bors mentioned this pull request Mar 25, 2024
Merged
@Young-Flash Young-Flash deleted the limit_struct_hover_display branch March 26, 2024 01:28
This was referenced May 9, 2024
Closed
Closed
Closed
Closed
Merged
This was referenced May 28, 2024
Merged
Closed
Closed
Closed
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 4, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 18, 2024
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Young-Flash @Veykril @bors @rustbot