Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix build scripts not being rebuilt in some occasions #16247

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jan 4, 2024

Also makes proc-macro changed flag setting async, we don't wanna block process_changes on the database as that is on the main thread!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2024
@lnicola
Copy link
Member

lnicola commented Jan 4, 2024

Needs a cargo test; git commit -a --amend.

@Veykril Veykril force-pushed the opqueues branch 2 times, most recently from 443fc29 to 4a99de5 Compare January 5, 2024 13:32
@lnicola

This comment was marked as off-topic.

@bors
Copy link
Collaborator

bors commented Jan 8, 2024

☔ The latest upstream changes (presumably #16307) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2024
@Veykril Veykril marked this pull request as draft January 10, 2024 12:40
@bors
Copy link
Collaborator

bors commented Jan 19, 2024

☔ The latest upstream changes (presumably #16398) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Jan 19, 2024

☔ The latest upstream changes (presumably #16404) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril Veykril force-pushed the opqueues branch 2 times, most recently from 15653b0 to 39637d7 Compare February 9, 2024 11:00
@bors
Copy link
Collaborator

bors commented Feb 10, 2024

☔ The latest upstream changes (presumably #16521) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril Veykril force-pushed the opqueues branch 3 times, most recently from 868c124 to 1d60f50 Compare February 14, 2024 11:32
@Veykril Veykril marked this pull request as ready for review February 14, 2024 11:32
@Veykril Veykril force-pushed the opqueues branch 2 times, most recently from 4fd5741 to fa4af62 Compare February 14, 2024 11:39
@Veykril
Copy link
Member Author

Veykril commented Feb 14, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 14, 2024

📌 Commit 1e6cef9 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 14, 2024

⌛ Testing commit 1e6cef9 with merge 3bb8d3a...

@bors
Copy link
Collaborator

bors commented Feb 14, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 3bb8d3a to master...

@bors bors merged commit 3bb8d3a into rust-lang:master Feb 14, 2024
10 of 11 checks passed
@Veykril Veykril deleted the opqueues branch February 20, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants