Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction for #asWord lemmas #2625

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Correction for #asWord lemmas #2625

merged 2 commits into from
Sep 19, 2024

Conversation

PetarMax
Copy link
Contributor

This PR adds the necessary requires clauses to ML-level simplifications for #asWord, which prevent infinite looping observed in the Kontrol test suite.

@PetarMax PetarMax added the bug Something isn't working label Sep 18, 2024
@PetarMax PetarMax self-assigned this Sep 18, 2024
Copy link
Member

@ehildenb ehildenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests that are infinite looping but now are not would be great! I guess since something is failing on Kontrol, you ahve an example that can be merged here.

@anvacaru anvacaru merged commit edd0a66 into master Sep 19, 2024
12 checks passed
@anvacaru anvacaru deleted the petar/as-word-correction branch September 19, 2024 05:26
@PetarMax
Copy link
Contributor Author

I tried, but wasn't able to create one in KEVM. The test that does the looping in Kontrol is TGovernance.getEscrowTokenTotalSupply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants