Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: add more precise explanation of various fixes #141

Open
AndroidDeveloperLB opened this issue Dec 17, 2020 · 5 comments
Open

Request: add more precise explanation of various fixes #141

AndroidDeveloperLB opened this issue Dec 17, 2020 · 5 comments

Comments

@AndroidDeveloperLB
Copy link

AndroidDeveloperLB commented Dec 17, 2020

I've found the next ones not specific enough:

  1. Doesn't say about Windows OS how to set JAVA_HOME (can be done via command line too, but would be nice to have both UI-based and command-line instructions), even though it's running on it:
A problem occurred configuring root project 'My Application'.
> =============================== Gradle Doctor Prescriptions ============================================
  | JAVA_HOME is not set.
                                                                               |
  | Please set JAVA_HOME so that switching between Android Studio and the terminal does not trigger a fu |
  | ll rebuild.
                                                                                         |
  | To set JAVA_HOME: (using bash)
                                                                      |
  | echo "export JAVA_HOME=$(/usr/libexec/java_home)" >> ~/.bash_profile
                                |
  | or `~/.zshrc` if using zsh.
                                                                         |
  |                                                                                                      |
  ========================================================================================================
  1. It doesn't say in which file to add "UseParallelGC" :
A problem occurred configuring root project 'My Application'.
> =============================== Gradle Doctor Prescriptions ============================================
  | For faster builds, use the parallel GC.                                                              |
  | Add -XX:+UseParallelGC to the org.gradle.jvmargs                                                     |
  ========================================================================================================

  1. Doesn't say where to add "doctor" exactly:
=============================== Gradle Doctor Prescriptions ============================================
| Jetifier was enabled which means your builds are slower by 4-20%.                                    |
| Here's an article to help you disable it:                                                            |
| https://adambennett.dev/2020/08/disabling-jetifier/                                                  |
|                                                                                                      |
| To disable this warning, configure the Gradle Doctor extension:                                      |
| doctor {                                                                                             |
|   warnWhenJetifierEnable.set(false)                                                                  |
| }                                                                                                    |
========================================================================================================
@runningcode
Copy link
Owner

Hey, thanks for filing this. These look like good improvements to our documentation as well as the Gradle Doctor itself. Please feel free to suggest and make changes with impoved wording.

@AndroidDeveloperLB
Copy link
Author

@runningcode Hello, is it possible for some of those to actually have a quick-fix instead of just text?
I also wonder about the suggestion of it to use JDK of the OS itself. I think it causes some issues which means it might not be a good tip. Today I got this issue and only going back to what the IDE has fixed it:
https://stackoverflow.com/q/37015872/878126

@runningcode
Copy link
Owner

Quick fixes sound great. Can you explain how you would like those to work? I'm also very open to PRs and improvements in this area.

I'm unfamiliar with that error. What version of Java were you trying? I think the newest fully supported version in Android Studio is JDK 11.

@AndroidDeveloperLB
Copy link
Author

AndroidDeveloperLB commented Jan 5, 2021

I don't think using JDK 11 is a good idea for Android Studio. I think it caused me some issues and I had to set it back.

As for the rest, sorry I don't know.

@runningcode
Copy link
Owner

Thanks. Please file bugs or reference them for any issues you encounter regarding JDK 11! JDK 11 will be the default JDK in Android Studio 4.2 (or 7 depending on how the version is named).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants