Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Statistics collection is disabled" for players #26

Closed
astromind opened this issue Mar 28, 2021 · 2 comments
Closed

"Statistics collection is disabled" for players #26

astromind opened this issue Mar 28, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@astromind
Copy link

Steps to reproduce:

In foundry settings - Permission configuration page give Player or Trusted player group the Modify configuration settings permission.
Login as (trusted) player.
Open libWrapper settings.

Observed:

User can't modify libWrapper settings.Priorities and Conflicts tabs are empty. "Statistics collection is disabled" message is displayed.

Expected:

User, who is given access to libWrapper settings, should be able to change them.

@ruipin
Copy link
Owner

ruipin commented Mar 28, 2021

Statistics collection is disabled for any non-GM user, as the assumption was they would not need to modify these settings anyway, and there's a (tiny) performance impact of it being enabled.

I had not thought about the "Modify configuration settings" permission. Thanks for the report, I'll look into fixing this.

@ruipin ruipin self-assigned this Mar 28, 2021
@ruipin ruipin added the bug Something isn't working label Mar 28, 2021
@ruipin ruipin closed this as completed in 1d15a53 Apr 11, 2021
@ruipin
Copy link
Owner

ruipin commented Apr 11, 2021

This is now fixed in v1.4.0.0, closing.

Feel free to comment or re-open if the issue (or something similar) still occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants