Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu #45

Closed
lionirdeadman opened this issue Jun 3, 2019 · 7 comments · Fixed by #137
Closed

Context menu #45

lionirdeadman opened this issue Jun 3, 2019 · 7 comments · Fixed by #137
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest 2020, https://hacktoberfest.digitalocean.com

Comments

@lionirdeadman
Copy link

Background

I think adding a context menu would be closer to what you type meaning there's less movement involved to activate it and it means I can have one less icon on the top bar. 😉

Proposed solution

Add context menu functionality

@lionirdeadman lionirdeadman added the enhancement New feature or request label Jun 3, 2019
@rugk
Copy link
Owner

rugk commented Jun 4, 2019

You know you can also use a hot key? (Did not you?)

Considering this hot key feature and the fact that you are likely actively typing when you want to insert an emoji, is not a hot key faster/more convenient/… to use?
What would justify another menu entry in such a case? (I mean, I just don't want to bloat people's context menu (unnecessarily)… that grows very fast if you have many add-ons.)

@lionirdeadman
Copy link
Author

I didn't actually but is it possible to make the emoji picker closer to the text? The purpose of the context menu in my mind was to not drag my mouse over there. (It also doesn't work if you remove the icon from the bar) 🤔

@rugk
Copy link
Owner

rugk commented Jun 4, 2019

It also doesn't work if you remove the icon from the bar

Put it into the overflow menu, then it should work at least. But if it is really hidden, yes, it obviously does not work. (BTW if you don't know: You can disabled the colored icon in the settings. Then it does not disturb so much, at least. 😉 Did you know that?)

I didn't actually but is it possible to make the emoji picker closer to the text?

#9 should cover this.

@lionirdeadman
Copy link
Author

(BTW if you don't know: You can disabled the colored icon in the settings. Then it does not disturb so much, at least. wink Did you know that?)

I did and it fits nicely there but.. I'm rather conservative with what I put there 😉

#9 should cover this.

I see, I'll subscribe to the issue and close this then. 🙏

@rugk
Copy link
Owner

rugk commented Jun 4, 2019

Yeah, that said, maybe there are anyway arguments in favor of a context menu (instead of only hot key) for the emoji picker. If you (or anyone else) thinks so, feel free to reopen/comment here.

@lionirdeadman
Copy link
Author

I mean, I know GNOME's emoji picker has both so there's a precedent for that behaviour. If you're worried that it might be unwanted, it could be an extension setting if possible.

@rugk
Copy link
Owner

rugk commented Jun 5, 2019

Hmm, so keeping it open for visibility…

@rugk rugk reopened this Jun 5, 2019
@rugk rugk added good first issue Good for newcomers hacktoberfest Hacktoberfest 2020, https://hacktoberfest.digitalocean.com labels Oct 17, 2020
@rugk rugk closed this as completed in #137 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest 2020, https://hacktoberfest.digitalocean.com
Projects
None yet
2 participants