From e109ac5b9d8cb78f828d3aef89f904d899343aed Mon Sep 17 00:00:00 2001
From: scimerman <sandi.cimerman@gmail.com>
Date: Tue, 6 Sep 2022 10:01:15 +0200
Subject: [PATCH 01/13] Created role 'backup_local' (with cronjob)

---
 group_vars/betabarrel_cluster/vars.yml        | 24 ++++-
 roles/backup_local/README.md                  | 92 +++++++++++++++++++
 roles/backup_local/defaults/main.yml          | 16 ++++
 roles/backup_local/meta/main.yml              |  4 +
 roles/backup_local/tasks/crons.yml            | 42 +++++++++
 roles/backup_local/tasks/main.yml             |  6 ++
 .../templates/backup_cronjob.sh.j2            | 91 ++++++++++++++++++
 7 files changed, 270 insertions(+), 5 deletions(-)
 create mode 100644 roles/backup_local/README.md
 create mode 100644 roles/backup_local/defaults/main.yml
 create mode 100644 roles/backup_local/meta/main.yml
 create mode 100644 roles/backup_local/tasks/crons.yml
 create mode 100644 roles/backup_local/tasks/main.yml
 create mode 100755 roles/backup_local/templates/backup_cronjob.sh.j2

diff --git a/group_vars/betabarrel_cluster/vars.yml b/group_vars/betabarrel_cluster/vars.yml
index 8a232dc9c..12b7c354f 100644
--- a/group_vars/betabarrel_cluster/vars.yml
+++ b/group_vars/betabarrel_cluster/vars.yml
@@ -29,7 +29,7 @@ use_ldap: yes
 create_ldap: no
 use_sssd: yes
 ldap_domains:
-  grunn:
+  default_domain:
     uri: ldaps://svrs.id.rug.nl
     search_base: ou=gd,o=asds
     schema: rfc2307
@@ -55,6 +55,19 @@ nameservers: [
   '8.8.4.4',  # Google DNS.
   '8.8.8.8',  # Google DNS.
 ]
+network_private_management_id: "{{ stack_prefix }}_internal_management"
+network_private_management_cidr: '10.10.1.0/24'
+network_private_management_gw: '10.10.1.1'
+#network_private_storage_id: "{{ stack_prefix }}_internal_storage"
+#network_private_storage_cidr: '10.10.2.0/24'
+
+backup_clist: # list of folders for cron to make daily backup
+  - name: apps # don't modify after once deployed!
+    src_path: '/apps'
+    frequency:
+     - { name: 'daily', hour: '5', minute: '47', day: '*', weekday: '*', month: '*', keep: '60', disabled: 'false' }
+#     - { name: 'weekly', hour: '*', minute: '*', day: '*', weekday: '*', month: '*', keep: '20', disabled: 'false' }
+
 local_admin_groups:
   - 'admin'
   - 'docker'
@@ -133,10 +146,11 @@ regular_users:
 #
 pfs_mounts:
   - pfs: local_raid
-    source:
-    type:
-    rw_options:
-    ro_options:
+    device: /local_raid  # needs to be already mounted on system (f.e. /dev/sdc1 > /local_raid)
+    source: '/mnt'
+    type: 'none'
+    rw_options: 'bind'
+    ro_options: 'bind,ro'
     machines: "{{ groups['sys_admin_interface'] }}"
   - pfs: 'medgen_zincfinger$'
     source: '//storage3.umcg.nl'
diff --git a/roles/backup_local/README.md b/roles/backup_local/README.md
new file mode 100644
index 000000000..bc54fcf42
--- /dev/null
+++ b/roles/backup_local/README.md
@@ -0,0 +1,92 @@
+## About
+
+Playbook creates the local backup (could be mounted from remote machine)  
+of local folder(s).
+
+The group variables (or machine variables) use the `backup_clist` for a list of  
+folders that needs to be backed up.
+
+The `types` sublist of the `backup_clist` define the frequency of backups. There  
+can be more than one type periodically occuring at the same time (f.e. `daily` and  
+`weekly` backups). This sublist also defines the months/weekdays/days/hours/minutes  
+of when the individual backup should occur.
+
+Cron jobs are defined and deployed, based on the naming of the backups. Make  
+sure you do not deploy the backup and then redeploy it with the changed name, as  
+it will result in duplicated cron jobs!
+
+# Backup size growth
+
+All the backup increments are hardlinked against last backup, in order to save  
+space. The hardlinking mechanism uses rsync's internal mechanism to do so.
+
+The cron will keep number of backups of individual folder, the oldest ones will  
+be automatically deleted upon execution of the new backup.
+
+For each `frequency` there will be one **full** copy, **plus** the differential backups for
+number of `keep` backups.
+
+## Data structure
+
+*   Main backup folder is the main location of all the backups to be added, f.e.  
+    `/backups/`
+*   a subfolder inside is the name of individual backup - f.e. if we define a  
+    backup of `/apps` and name it `apps` there will be  
+    `/backups/apps`
+*   an individual backup can have more than one frequency defined, so there will
+    be a subfolder for each frequency.
+
+## Cron execution
+
+There is a cron call for each of the backup and for each of frequency created with
+this playbook automatically. It can be viewed with `crontab -l`. The crons should
+not be changed manually!
+
+## Script procedure
+
+1.  Script checks if the backup folders of source and destination exists.
+2.  It removes the number of past backups if there is more of them than the set number.
+3.  It determins the latest backup folder.
+4.  It creates a new backup in `main backup > name > frequency` directory, with  
+    the hardlink to the last backups of this backup type.
+
+## Manually executing
+
+You can also call the backup command with:
+
+`/root/backup_cronjob.sh etc daily 10 /etc /backups/`
+
+this will make the backup of `/etc` folder, will put the files in
+
+`/backups/etc/daily/YYYYmmdd_HHMMSS/etc/`
+
+and keep all together last 10 backups.
+
+## Logging
+
+The list of deleted folders, and the rsync entire command (before execution) is
+logged into a file /root/backup_cron.sh.log (that is `${0}.log`).
+The output of command also show the hardlinking of the folders, if needed for
+debugging.
+Log is also rotated and kept only last 1024 lines.
+
+## Tested
+
+With `ansible-lint v6.5.0` and `shellcheck v0.8.0`.
+
+## Limitations
+
+The script itself cannot be executed more than once per second. It was not yet
+tested for the backups on the external machines.
+
+Successful backup has no output. The output appears only when errors occur. In
+the current configuration, the failed backup output is reported only in the mails
+for the `root` user (at the moment that is in the `/var/spool/mail/root` or
+`/var/mail/root`).
+
+Do not use this backup methods for
+
+  - the backup of the files, whose content change just slightly (f.e. appended
+    new line at the end of large file (f.e. backup of large database dumps)
+  - folder who has regular newly created files, that get later deleted (f.e. the
+    ones in the /tmp folder)
diff --git a/roles/backup_local/defaults/main.yml b/roles/backup_local/defaults/main.yml
new file mode 100644
index 000000000..c9e17cf6d
--- /dev/null
+++ b/roles/backup_local/defaults/main.yml
@@ -0,0 +1,16 @@
+---
+# list of list of folders for cron to make daily backup
+# Example values:
+# backup_clist: # list of folders for cron to make daily backup
+#   - name: apps # don't modify after once deployed!
+#     src_path: '/apps'
+#     frequency:
+#      - { name: 'daily', hour: '*', minute: '*', day: '*', weekday: '*', month: '*', keep: '60', disabled: 'false' }
+#      - { name: 'weekly', hour: '*', minute: '*/3', day: '*', weekday: '*', month: '*', keep: '20', disabled: 'false' }
+
+
+# By default an empty list
+backup_clist: []
+
+main_backup_folder: '/backups/'        # where to save all the backups on the individual machine
+...
diff --git a/roles/backup_local/meta/main.yml b/roles/backup_local/meta/main.yml
new file mode 100644
index 000000000..b6c4dc8d4
--- /dev/null
+++ b/roles/backup_local/meta/main.yml
@@ -0,0 +1,4 @@
+---
+dependencies:
+    - role: rsync
+...
diff --git a/roles/backup_local/tasks/crons.yml b/roles/backup_local/tasks/crons.yml
new file mode 100644
index 000000000..a1d7ad9d8
--- /dev/null
+++ b/roles/backup_local/tasks/crons.yml
@@ -0,0 +1,42 @@
+---
+
+- name: Create main backup directory
+  ansible.builtin.file:
+    path: '{{ main_backup_folder }}'
+    state: directory
+    mode: '0755'
+  become: true
+
+- name: Create backup subdirectories for each item from list
+  ansible.builtin.file:
+    path: '{{ main_backup_folder }}/{{ item.name }}/'
+    state: directory
+    mode: '0700'
+  become: true
+  loop: "{{ backup_clist }}"
+
+- name: 'Install backup cronjob script'
+  ansible.builtin.template:
+    src: "templates/backup_cronjob.sh.j2"
+    dest: '/root/backup_cronjob.sh'
+    owner: 'root'
+    group: 'root'
+    mode: '0700'
+  become: true
+
+- name: 'Create cron for daily backup'
+  ansible.builtin.cron:
+    name: '{{ item.0.name }}-{{ item.1.name }} - do not change it manually!'
+    hour: '{{ item.1.hour }}'
+    minute: '{{ item.1.minute }}'
+    month: '{{ item.1.month }}'
+    weekday: '{{ item.1.weekday }}'
+    user: 'root'
+    disabled: '{{ item.1.disabled | default("true") }}'
+    job: >
+      /root/backup_cronjob.sh "{{ item.0.name }}" "{{ item.1.name }}" "{{ item.1.keep }}"
+      "{{ item.0.src_path }}" "{{ main_backup_folder | default("/backups/", true) }}"
+  loop: '{{ backup_clist | subelements("frequency") }}'
+  become: true
+
+...
diff --git a/roles/backup_local/tasks/main.yml b/roles/backup_local/tasks/main.yml
new file mode 100644
index 000000000..7a587c462
--- /dev/null
+++ b/roles/backup_local/tasks/main.yml
@@ -0,0 +1,6 @@
+---
+
+- name: Install and configure local backup cron
+  ansible.builtin.include_tasks: crons.yml
+
+...
diff --git a/roles/backup_local/templates/backup_cronjob.sh.j2 b/roles/backup_local/templates/backup_cronjob.sh.j2
new file mode 100755
index 000000000..e5bca3775
--- /dev/null
+++ b/roles/backup_local/templates/backup_cronjob.sh.j2
@@ -0,0 +1,91 @@
+#!/bin/bash
+
+# 2022-08-22 initial script
+# 2022-08-23 added options: type, keepversions and destionation, shellcheck done
+# 2022-08-24 added logging, debugging
+# 2022-08-28 improved logging, worked on initial backup
+# {% raw %}
+
+set -e
+set -u 
+set -o pipefail
+
+if [ "${#}" -ne 5 ]; then
+   echo "${0} \"name\" \"frequencyname\" \"keep\" \"/this/will/be/backed/up\" \"/destination/path\""
+   echo "   name                [string] name of the backup (creates subdirectory main>name)"
+   echo "   frequencyname       [string] frequency name of backup (creates subdirectory main>name>frequency)"
+   echo "   keep                [number] how many backups to keep for this frequency"
+   echo "   /source/...         [/path/...] to the folder that you would like to backup"
+   echo "   /main/bckp/dst/...  [/path/...] to the *main* backup folder to keep all the backups"
+   exit 1 
+fi
+
+# Get script arguments
+backup_name="${1}"
+backup_frequency="${2}"
+keep_versions="${3}"
+main_backup_destination="${5}"
+
+current_time="$(date +%Y%m%d_%H%M%S)"
+
+log_file="${main_backup_destination}/${backup_name}/log"
+touch "${log_file}"
+original_directory="$(pwd)"
+
+# Check the if source directory exists and is readble
+if ! test -r "${4}"; then
+  echo "Error, (source) directory for backing up cannot be read/does not exist:"
+  echo " -> ${4}"
+  exit 255
+else
+  backup_source_formatted="$(cd "${4}" && pwd)"
+fi
+
+# Check if the main destination backup folder exist
+if ! test -d "${main_backup_destination}/${backup_name}"; then
+  echo "Error, one or more (destination) directories do not exist:"
+  echo " -> ${main_backup_destination}/${backup_name}"
+  exit 255
+fi
+
+frequency_dir="${main_backup_destination}/${backup_name}/${backup_frequency}"
+# Check the destination subdirectories and create them if missing
+# Assemble the destination directory path, but do not create directory yet
+destination_dir="${frequency_dir}/${current_time}/${backup_source_formatted}/"
+
+test -d "${frequency_dir}" || mkdir "${frequency_dir:-}"
+
+# Clean old logs (and keep only last 1024 lines)
+log_short="$(tail -n 1024 "${log_file}")"
+echo "${log_short}" > "${log_file}"
+
+# Clean old backups
+# list daily versions, sort by time, and keep only number of them, rest delete
+# ! -path . suppreses '.' from output
+purge_list="$(cd "${frequency_dir}" && find . -maxdepth 1 ! -path . -type d -printf '%T@ %f\n' | sort -r | cut -d' ' -f2- | tail -n +"${keep_versions}")"
+if [[ ! -z "${purge_list}" ]]; then echo -e "${current_time}: purging ${purge_list}" >> "${log_file}"; fi
+# ! -path . suppreses '.' from output
+cd "${frequency_dir}" && find . -maxdepth 1 ! -path . -type d -printf '%T@ %f\n' | sort -r | cut -d' ' -f2- | tail -n +"$((keep_versions + 1))" | xargs -I {} rm -rf -- ./{}
+
+# FIND LAST DAILY BACKUP
+# sort by modification time, newest first
+# ! -path . suppreses '.' from output
+latest_backup="$(cd "${frequency_dir}" && find . -maxdepth 1 ! -path . -type d -printf '%T@ %f\n' | sort -r | cut -d' ' -f2- | head -n 1)" # take first
+
+# Assemble the command for initial vs incremental backup
+if [[ -z "${latest_backup}" ]]; then # first backup = simple copy, as no lattest directory found
+   backup_command="rsync -aqH --protect-args --delete ${backup_source_formatted}/ ${destination_dir}/."
+else # make the incremental backup with hard-link against latest
+   # (link-dest has relative path against the new backup folder)
+   backup_command="rsync -aqH --protect-args --delete ${backup_source_formatted}/ ${destination_dir}/. --link-dest=../${latest_backup}"
+fi
+
+# Make the destination directory
+mkdir -p "${destination_dir}"
+# Log the backup command
+echo "${current_time}: ${backup_command}" >> "${log_file}"
+# Execute the command
+eval "${backup_command}"
+
+cd "${original_directory}" # return to home directory
+# {% endraw %}

From 6363614cefb3ad8185764ebc034b72ac28429a08 Mon Sep 17 00:00:00 2001
From: scimerman <sandi.cimerman@gmail.com>
Date: Tue, 6 Sep 2022 10:03:49 +0200
Subject: [PATCH 02/13] backup_local: added single_role

---
 single_role_playbooks/backup_local.yml | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 single_role_playbooks/backup_local.yml

diff --git a/single_role_playbooks/backup_local.yml b/single_role_playbooks/backup_local.yml
new file mode 100644
index 000000000..cf9505f5a
--- /dev/null
+++ b/single_role_playbooks/backup_local.yml
@@ -0,0 +1,6 @@
+---
+- hosts:
+    - deploy_admin_interface
+  roles:
+    - backup_cronjob
+...

From 402e160a4680d9b28e30a538e723c3af429c0990 Mon Sep 17 00:00:00 2001
From: scimerman <sandi.cimerman@gmail.com>
Date: Tue, 6 Sep 2022 10:05:59 +0200
Subject: [PATCH 03/13] backup_local: added BB variables

---
 group_vars/betabarrel_cluster/vars.yml | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/group_vars/betabarrel_cluster/vars.yml b/group_vars/betabarrel_cluster/vars.yml
index 12b7c354f..83a291271 100644
--- a/group_vars/betabarrel_cluster/vars.yml
+++ b/group_vars/betabarrel_cluster/vars.yml
@@ -55,18 +55,12 @@ nameservers: [
   '8.8.4.4',  # Google DNS.
   '8.8.8.8',  # Google DNS.
 ]
-network_private_management_id: "{{ stack_prefix }}_internal_management"
-network_private_management_cidr: '10.10.1.0/24'
-network_private_management_gw: '10.10.1.1'
-#network_private_storage_id: "{{ stack_prefix }}_internal_storage"
-#network_private_storage_cidr: '10.10.2.0/24'
 
 backup_clist: # list of folders for cron to make daily backup
   - name: apps # don't modify after once deployed!
     src_path: '/apps'
     frequency:
      - { name: 'daily', hour: '5', minute: '47', day: '*', weekday: '*', month: '*', keep: '60', disabled: 'false' }
-#     - { name: 'weekly', hour: '*', minute: '*', day: '*', weekday: '*', month: '*', keep: '20', disabled: 'false' }
 
 local_admin_groups:
   - 'admin'
@@ -146,12 +140,10 @@ regular_users:
 #
 pfs_mounts:
   - pfs: local_raid
-    device: /local_raid  # needs to be already mounted on system (f.e. /dev/sdc1 > /local_raid)
-    source: '/mnt'
-    type: 'none'
-    rw_options: 'bind'
-    ro_options: 'bind,ro'
-    machines: "{{ groups['sys_admin_interface'] }}"
+    source:
+    type:
+    rw_options:
+    ro_options:
   - pfs: 'medgen_zincfinger$'
     source: '//storage3.umcg.nl'
     type: cifs    # checked with cat /proc/filesystem

From c3c7f18cb98f93a36137a07bdb0014a03bbb34cf Mon Sep 17 00:00:00 2001
From: scimerman <sandi.cimerman@gmail.com>
Date: Tue, 6 Sep 2022 10:06:41 +0200
Subject: [PATCH 04/13] backup_local: update

---
 group_vars/betabarrel_cluster/vars.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/group_vars/betabarrel_cluster/vars.yml b/group_vars/betabarrel_cluster/vars.yml
index 83a291271..abb1d0cda 100644
--- a/group_vars/betabarrel_cluster/vars.yml
+++ b/group_vars/betabarrel_cluster/vars.yml
@@ -29,7 +29,7 @@ use_ldap: yes
 create_ldap: no
 use_sssd: yes
 ldap_domains:
-  default_domain:
+  grunn:
     uri: ldaps://svrs.id.rug.nl
     search_base: ou=gd,o=asds
     schema: rfc2307

From 5d872ad3980b68cbf1d791293ba460c408ad0ccd Mon Sep 17 00:00:00 2001
From: scimerman <sandi.cimerman@gmail.com>
Date: Tue, 6 Sep 2022 10:07:25 +0200
Subject: [PATCH 05/13] backup_local: update

---
 group_vars/betabarrel_cluster/vars.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/group_vars/betabarrel_cluster/vars.yml b/group_vars/betabarrel_cluster/vars.yml
index abb1d0cda..a2f5741a3 100644
--- a/group_vars/betabarrel_cluster/vars.yml
+++ b/group_vars/betabarrel_cluster/vars.yml
@@ -144,6 +144,7 @@ pfs_mounts:
     type:
     rw_options:
     ro_options:
+    machines: "{{ groups['sys_admin_interface'] }}"
   - pfs: 'medgen_zincfinger$'
     source: '//storage3.umcg.nl'
     type: cifs    # checked with cat /proc/filesystem

From a40403bf78bea330c0552610caa25f022da280b6 Mon Sep 17 00:00:00 2001
From: scimerman <sandi.cimerman@gmail.com>
Date: Tue, 6 Sep 2022 10:08:25 +0200
Subject: [PATCH 06/13] backup_local: included into playbooks

---
 single_group_playbooks/cluster_part2.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/single_group_playbooks/cluster_part2.yml b/single_group_playbooks/cluster_part2.yml
index a3745d5e0..a80903073 100644
--- a/single_group_playbooks/cluster_part2.yml
+++ b/single_group_playbooks/cluster_part2.yml
@@ -18,4 +18,5 @@
     - lustre_client
     - nfs_client
     - shared_storage
+    - backup_local
 ...

From b00435c727acb67241b67a3c2509eeffeac7cf65 Mon Sep 17 00:00:00 2001
From: scimerman <sandi.cimerman@gmail.com>
Date: Tue, 6 Sep 2022 10:10:20 +0200
Subject: [PATCH 07/13] backup_local: bugfix

---
 single_role_playbooks/backup_local.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/single_role_playbooks/backup_local.yml b/single_role_playbooks/backup_local.yml
index cf9505f5a..30ec9c820 100644
--- a/single_role_playbooks/backup_local.yml
+++ b/single_role_playbooks/backup_local.yml
@@ -2,5 +2,5 @@
 - hosts:
     - deploy_admin_interface
   roles:
-    - backup_cronjob
+    - backup_local
 ...

From c64210861263d6aa8018536a92a07efd26d30813 Mon Sep 17 00:00:00 2001
From: scimerman <sandi.cimerman@gmail.com>
Date: Tue, 6 Sep 2022 10:32:58 +0200
Subject: [PATCH 08/13] backup_local: fixed when the playbooks should be
 triggered

---
 roles/backup_local/tasks/crons.yml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/roles/backup_local/tasks/crons.yml b/roles/backup_local/tasks/crons.yml
index a1d7ad9d8..5fb01ccea 100644
--- a/roles/backup_local/tasks/crons.yml
+++ b/roles/backup_local/tasks/crons.yml
@@ -5,6 +5,7 @@
     path: '{{ main_backup_folder }}'
     state: directory
     mode: '0755'
+  when: backup_clist is defined and backup_clist | default([]) | length > 0 
   become: true
 
 - name: Create backup subdirectories for each item from list
@@ -12,6 +13,7 @@
     path: '{{ main_backup_folder }}/{{ item.name }}/'
     state: directory
     mode: '0700'
+  when: backup_clist is defined and backup_clist | default([]) | length > 0 
   become: true
   loop: "{{ backup_clist }}"
 
@@ -22,6 +24,7 @@
     owner: 'root'
     group: 'root'
     mode: '0700'
+  when: backup_clist is defined and backup_clist | default([]) | length > 0 
   become: true
 
 - name: 'Create cron for daily backup'
@@ -34,8 +37,8 @@
     user: 'root'
     disabled: '{{ item.1.disabled | default("true") }}'
     job: >
-      /root/backup_cronjob.sh "{{ item.0.name }}" "{{ item.1.name }}" "{{ item.1.keep }}"
-      "{{ item.0.src_path }}" "{{ main_backup_folder | default("/backups/", true) }}"
+      /root/backup_cronjob.sh '{{ item.0.name }}' '{{ item.1.name }}' '{{ item.1.keep }}'
+      '{{ item.0.src_path }}' '{{ main_backup_folder | default("/backups/", true) }}'
   loop: '{{ backup_clist | subelements("frequency") }}'
   become: true
 

From 3f8f0133ad9025a3001c2262deeaee27cd5d1386 Mon Sep 17 00:00:00 2001
From: scimerman <sandi.cimerman@gmail.com>
Date: Tue, 6 Sep 2022 10:40:36 +0200
Subject: [PATCH 09/13] backup_local: update

---
 roles/backup_local/README.md         | 24 +++++++++++++-----------
 roles/backup_local/defaults/main.yml |  2 +-
 2 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/roles/backup_local/README.md b/roles/backup_local/README.md
index bc54fcf42..8b3687176 100644
--- a/roles/backup_local/README.md
+++ b/roles/backup_local/README.md
@@ -1,19 +1,21 @@
 ## About
 
-Playbook creates the local backup (could be mounted from remote machine)  
-of local folder(s).
+Playbook creates the local backup of local folder(s).
 
 The group variables (or machine variables) use the `backup_clist` for a list of  
 folders that needs to be backed up.
 
-The `types` sublist of the `backup_clist` define the frequency of backups. There  
-can be more than one type periodically occuring at the same time (f.e. `daily` and  
-`weekly` backups). This sublist also defines the months/weekdays/days/hours/minutes  
-of when the individual backup should occur.
+The `types` sublist of the `backup_clist` define the frequency of backups. It can
+be multiple periodical backups running at the same time on the machine (f.e. `daily`
+and `weekly` backups). Per each of backup inside `backup_clist`, there is a date
+and time definition of when this type of backup should occur.
 
-Cron jobs are defined and deployed, based on the naming of the backups. Make  
-sure you do not deploy the backup and then redeploy it with the changed name, as  
-it will result in duplicated cron jobs!
+Cronjobs are defined and deployed, based on the naming of the backups. Make sure
+that you do not deploy the backup and then redeploy it with the changed name, as  
+it will result in duplicated cron jobs.
+
+Destination of the backup folder can be also a mounted directory from the remote
+server.
 
 # Backup size growth
 
@@ -23,8 +25,8 @@ space. The hardlinking mechanism uses rsync's internal mechanism to do so.
 The cron will keep number of backups of individual folder, the oldest ones will  
 be automatically deleted upon execution of the new backup.
 
-For each `frequency` there will be one **full** copy, **plus** the differential backups for
-number of `keep` backups.
+For each `frequency` there will be one **full** copy, **plus** the differential
+backups for number of `keep` backups.
 
 ## Data structure
 
diff --git a/roles/backup_local/defaults/main.yml b/roles/backup_local/defaults/main.yml
index c9e17cf6d..49c0edde6 100644
--- a/roles/backup_local/defaults/main.yml
+++ b/roles/backup_local/defaults/main.yml
@@ -12,5 +12,5 @@
 # By default an empty list
 backup_clist: []
 
-main_backup_folder: '/backups/'        # where to save all the backups on the individual machine
+main_backup_folder: '/local_backups/'        # where to save all the backups on the individual machine
 ...

From ccf42b538c31a1d5d9ba89b133781514b37e44db Mon Sep 17 00:00:00 2001
From: scimerman <sandi.cimerman@gmail.com>
Date: Tue, 6 Sep 2022 10:45:25 +0200
Subject: [PATCH 10/13] backup_local: fix when should be executed dependency

---
 roles/backup_local/meta/main.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/roles/backup_local/meta/main.yml b/roles/backup_local/meta/main.yml
index b6c4dc8d4..31f9f4677 100644
--- a/roles/backup_local/meta/main.yml
+++ b/roles/backup_local/meta/main.yml
@@ -1,4 +1,5 @@
 ---
 dependencies:
     - role: rsync
+      when: backup_clist is defined and backup_clist | default([]) | length > 0
 ...

From 972713b7fcea3f339ff45c5c4425a5457c1b0e09 Mon Sep 17 00:00:00 2001
From: scimerman <sandi.cimerman@gmail.com>
Date: Tue, 6 Sep 2022 10:52:46 +0200
Subject: [PATCH 11/13] fix spaces error

---
 roles/backup_local/tasks/crons.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/roles/backup_local/tasks/crons.yml b/roles/backup_local/tasks/crons.yml
index 5fb01ccea..e002cbe0e 100644
--- a/roles/backup_local/tasks/crons.yml
+++ b/roles/backup_local/tasks/crons.yml
@@ -5,7 +5,7 @@
     path: '{{ main_backup_folder }}'
     state: directory
     mode: '0755'
-  when: backup_clist is defined and backup_clist | default([]) | length > 0 
+  when: backup_clist is defined and backup_clist | default([]) | length > 0
   become: true
 
 - name: Create backup subdirectories for each item from list
@@ -13,7 +13,7 @@
     path: '{{ main_backup_folder }}/{{ item.name }}/'
     state: directory
     mode: '0700'
-  when: backup_clist is defined and backup_clist | default([]) | length > 0 
+  when: backup_clist is defined and backup_clist | default([]) | length > 0
   become: true
   loop: "{{ backup_clist }}"
 
@@ -24,7 +24,7 @@
     owner: 'root'
     group: 'root'
     mode: '0700'
-  when: backup_clist is defined and backup_clist | default([]) | length > 0 
+  when: backup_clist is defined and backup_clist | default([]) | length > 0
   become: true
 
 - name: 'Create cron for daily backup'

From 4572b67943ce409741357bea50162ffaf57a716a Mon Sep 17 00:00:00 2001
From: scimerman <sandi.cimerman@gmail.com>
Date: Wed, 7 Sep 2022 14:11:30 +0200
Subject: [PATCH 12/13] backup_local renamed to clist renamed to local_backups

---
 group_vars/betabarrel_cluster/vars.yml |  2 +-
 roles/backup_local/README.md           |  6 +++---
 roles/backup_local/defaults/main.yml   |  4 ++--
 roles/backup_local/meta/main.yml       |  2 +-
 roles/backup_local/tasks/crons.yml     | 10 +++++-----
 5 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/group_vars/betabarrel_cluster/vars.yml b/group_vars/betabarrel_cluster/vars.yml
index a2f5741a3..ad9da7aa4 100644
--- a/group_vars/betabarrel_cluster/vars.yml
+++ b/group_vars/betabarrel_cluster/vars.yml
@@ -56,7 +56,7 @@ nameservers: [
   '8.8.8.8',  # Google DNS.
 ]
 
-backup_clist: # list of folders for cron to make daily backup
+local_backups: # list of folders for cron to make daily backup
   - name: apps # don't modify after once deployed!
     src_path: '/apps'
     frequency:
diff --git a/roles/backup_local/README.md b/roles/backup_local/README.md
index 8b3687176..fa8079e91 100644
--- a/roles/backup_local/README.md
+++ b/roles/backup_local/README.md
@@ -2,12 +2,12 @@
 
 Playbook creates the local backup of local folder(s).
 
-The group variables (or machine variables) use the `backup_clist` for a list of  
+The group variables (or machine variables) use the `local_backups` for a list of
 folders that needs to be backed up.
 
-The `types` sublist of the `backup_clist` define the frequency of backups. It can
+The `frequency` sublist of the `local_backups` define the frequency of backups. It can
 be multiple periodical backups running at the same time on the machine (f.e. `daily`
-and `weekly` backups). Per each of backup inside `backup_clist`, there is a date
+and `weekly` backups). Per each of backup inside `local_backups`, there is a date
 and time definition of when this type of backup should occur.
 
 Cronjobs are defined and deployed, based on the naming of the backups. Make sure
diff --git a/roles/backup_local/defaults/main.yml b/roles/backup_local/defaults/main.yml
index 49c0edde6..2ed4c7f58 100644
--- a/roles/backup_local/defaults/main.yml
+++ b/roles/backup_local/defaults/main.yml
@@ -1,7 +1,7 @@
 ---
 # list of list of folders for cron to make daily backup
 # Example values:
-# backup_clist: # list of folders for cron to make daily backup
+# local_backups: # list of folders for cron to make daily backup
 #   - name: apps # don't modify after once deployed!
 #     src_path: '/apps'
 #     frequency:
@@ -10,7 +10,7 @@
 
 
 # By default an empty list
-backup_clist: []
+local_backups: []
 
 main_backup_folder: '/local_backups/'        # where to save all the backups on the individual machine
 ...
diff --git a/roles/backup_local/meta/main.yml b/roles/backup_local/meta/main.yml
index 31f9f4677..670fb2879 100644
--- a/roles/backup_local/meta/main.yml
+++ b/roles/backup_local/meta/main.yml
@@ -1,5 +1,5 @@
 ---
 dependencies:
     - role: rsync
-      when: backup_clist is defined and backup_clist | default([]) | length > 0
+      when: local_backups is defined and backup_clist | default([]) | length > 0
 ...
diff --git a/roles/backup_local/tasks/crons.yml b/roles/backup_local/tasks/crons.yml
index e002cbe0e..9e8eeffe1 100644
--- a/roles/backup_local/tasks/crons.yml
+++ b/roles/backup_local/tasks/crons.yml
@@ -5,7 +5,7 @@
     path: '{{ main_backup_folder }}'
     state: directory
     mode: '0755'
-  when: backup_clist is defined and backup_clist | default([]) | length > 0
+  when: local_backups is defined and local_backups | default([]) | length > 0
   become: true
 
 - name: Create backup subdirectories for each item from list
@@ -13,9 +13,9 @@
     path: '{{ main_backup_folder }}/{{ item.name }}/'
     state: directory
     mode: '0700'
-  when: backup_clist is defined and backup_clist | default([]) | length > 0
+  when: local_backups is defined and local_backups | default([]) | length > 0
   become: true
-  loop: "{{ backup_clist }}"
+  loop: "{{ local_backups }}"
 
 - name: 'Install backup cronjob script'
   ansible.builtin.template:
@@ -24,7 +24,7 @@
     owner: 'root'
     group: 'root'
     mode: '0700'
-  when: backup_clist is defined and backup_clist | default([]) | length > 0
+  when: local_backups is defined and local_backups | default([]) | length > 0
   become: true
 
 - name: 'Create cron for daily backup'
@@ -39,7 +39,7 @@
     job: >
       /root/backup_cronjob.sh '{{ item.0.name }}' '{{ item.1.name }}' '{{ item.1.keep }}'
       '{{ item.0.src_path }}' '{{ main_backup_folder | default("/backups/", true) }}'
-  loop: '{{ backup_clist | subelements("frequency") }}'
+  loop: '{{ local_backups | subelements("frequency") }}'
   become: true
 
 ...

From bce154e8920721ba8af94e19bcb28db8b8beb53f Mon Sep 17 00:00:00 2001
From: scimerman <80223690+scimerman@users.noreply.github.com>
Date: Wed, 7 Sep 2022 14:14:19 +0200
Subject: [PATCH 13/13] Update roles/backup_local/README.md

Co-authored-by: Pieter Neerincx <pieter.neerincx@gmail.com>
---
 roles/backup_local/README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/roles/backup_local/README.md b/roles/backup_local/README.md
index fa8079e91..e7e7a5ad7 100644
--- a/roles/backup_local/README.md
+++ b/roles/backup_local/README.md
@@ -1,6 +1,6 @@
 ## About
 
-Playbook creates the local backup of local folder(s).
+This role can create a local backup of local folder(s).
 
 The group variables (or machine variables) use the `local_backups` for a list of
 folders that needs to be backed up.