From ee1c86cf701730506e97b53616e2c59d46a6006b Mon Sep 17 00:00:00 2001 From: Pieter Neerincx Date: Thu, 16 Feb 2023 18:47:03 +0100 Subject: [PATCH] Fixed new linter issues. --- roles/grafana/meta/main.yml | 2 +- roles/grafana/tasks/main.yml | 4 ++-- roles/grafana_proxy/tasks/main.yml | 4 ++-- roles/iptables/tasks/main.yml | 2 +- roles/pulp_server/tasks/main.yml | 4 ++-- roles/rsyslog_client/tasks/client.yml | 4 ++-- roles/rsyslog_client/tasks/deploy.yml | 6 +++--- roles/rsyslog_server/tasks/create_ca.yml | 2 +- roles/rsyslog_server/tasks/rsyslog.yml | 2 +- roles/ssh_known_hosts/tasks/main.yml | 2 +- roles/static_hostname_lookup/tasks/main.yml | 2 +- roles/swap/tasks/enable_swap.yml | 2 +- 12 files changed, 18 insertions(+), 18 deletions(-) diff --git a/roles/grafana/meta/main.yml b/roles/grafana/meta/main.yml index a957ba5ad..490d3911f 100644 --- a/roles/grafana/meta/main.yml +++ b/roles/grafana/meta/main.yml @@ -3,7 +3,7 @@ galaxy_info: role_name: grafana author: Pieter Neerincx (UMCG) Egon Rijpkema (UG) description: runs grafana in a docker container. - min_ansible_version: 2.4 + min_ansible_version: '2.4' license: "license (GPLv3)" platforms: - name: CentOS diff --git a/roles/grafana/tasks/main.yml b/roles/grafana/tasks/main.yml index 7c05eed17..238814058 100644 --- a/roles/grafana/tasks/main.yml +++ b/roles/grafana/tasks/main.yml @@ -3,7 +3,7 @@ ansible.builtin.file: path: "{{ item }}" state: directory - mode: 0755 + mode: '0755' owner: '65534' with_items: - '/srv/grafana/lib' @@ -15,7 +15,7 @@ ansible.builtin.template: src: 'templates/grafana.service' dest: '/etc/systemd/system/grafana.service' - mode: 0644 + mode: '0644' owner: root group: root tags: diff --git a/roles/grafana_proxy/tasks/main.yml b/roles/grafana_proxy/tasks/main.yml index ba197fbc1..608edc0da 100644 --- a/roles/grafana_proxy/tasks/main.yml +++ b/roles/grafana_proxy/tasks/main.yml @@ -10,7 +10,7 @@ ansible.builtin.template: src: templates/nginx.conf dest: /etc/nginx/nginx.conf - mode: 0644 + mode: '0644' owner: root group: root become: true @@ -19,7 +19,7 @@ ansible.builtin.file: path: /etc/certificates/live/airlock.hpc.rug.nl state: directory - mode: 0751 + mode: '0751' become: true - name: Copy certificate and chain files in place. diff --git a/roles/iptables/tasks/main.yml b/roles/iptables/tasks/main.yml index 6b94b7975..aa4b8af37 100644 --- a/roles/iptables/tasks/main.yml +++ b/roles/iptables/tasks/main.yml @@ -72,7 +72,7 @@ dest: '/etc/sysconfig/iptables-init.bash' owner: root group: root - mode: 0700 + mode: '0700' notify: configure_iptables become: true diff --git a/roles/pulp_server/tasks/main.yml b/roles/pulp_server/tasks/main.yml index f10bdaf0a..bee8098e4 100644 --- a/roles/pulp_server/tasks/main.yml +++ b/roles/pulp_server/tasks/main.yml @@ -188,7 +188,7 @@ ansible.builtin.template: src: templates/repo_management_user.netrc.j2 dest: "/admin/{{ repo_management_user }}/.netrc" - mode: 0600 + mode: '0600' owner: "{{ repo_management_user }}" group: "{{ repo_management_user }}" become: true @@ -198,7 +198,7 @@ ansible.builtin.template: src: templates/repo_management_user.settings.toml.j2 dest: "/admin/{{ repo_management_user }}/.config/pulp/settings.toml" - mode: 0600 + mode: '0600' owner: "{{ repo_management_user }}" group: "{{ repo_management_user }}" become: true diff --git a/roles/rsyslog_client/tasks/client.yml b/roles/rsyslog_client/tasks/client.yml index 0323f9bea..7a41cc2cb 100644 --- a/roles/rsyslog_client/tasks/client.yml +++ b/roles/rsyslog_client/tasks/client.yml @@ -50,7 +50,7 @@ ansible.builtin.template: src: templates/client_template.csr dest: /tmp/client_template.csr - mode: 0600 + mode: '0600' force: true when: not remote_client_key_status.stat.exists or verify_certificate_result.rc == 1 @@ -100,7 +100,7 @@ ansible.builtin.template: src: templates/client_template.csr dest: /tmp/{{ inventory_hostname }}_client_template.csr - mode: 0600 + mode: '0600' force: true become: true when: not remote_client_key_status.stat.exists or verify_certificate_result.rc == 1 diff --git a/roles/rsyslog_client/tasks/deploy.yml b/roles/rsyslog_client/tasks/deploy.yml index bba4ce6b7..ad650f98f 100644 --- a/roles/rsyslog_client/tasks/deploy.yml +++ b/roles/rsyslog_client/tasks/deploy.yml @@ -19,7 +19,7 @@ src: templates/rsyslog.conf dest: /etc/rsyslog.conf force: true - mode: 0644 + mode: '0644' become: true when: inventory_hostname not in groups['rsyslog'] notify: client_restart_rsyslog @@ -29,7 +29,7 @@ src: templates/rsyslog_managed.conf dest: /etc/rsyslog.d/managed.conf force: true - mode: 0644 + mode: '0644' become: true when: inventory_hostname not in groups['rsyslog'] notify: client_restart_rsyslog @@ -39,7 +39,7 @@ src: templates/rsyslog_unmanaged.conf dest: /etc/rsyslog.d/unmanaged.conf force: true - mode: 0644 + mode: '0644' become: true when: inventory_hostname not in groups['rsyslog'] notify: client_restart_rsyslog diff --git a/roles/rsyslog_server/tasks/create_ca.yml b/roles/rsyslog_server/tasks/create_ca.yml index 56ce27f93..b559bf410 100644 --- a/roles/rsyslog_server/tasks/create_ca.yml +++ b/roles/rsyslog_server/tasks/create_ca.yml @@ -24,7 +24,7 @@ ansible.builtin.template: src: roles/rsyslog_server/templates/ca.template dest: /tmp/ca.template - mode: 0600 + mode: '0600' when: not ca_key_on_server.stat.exists - name: Generate CA cert on managed rsyslog server diff --git a/roles/rsyslog_server/tasks/rsyslog.yml b/roles/rsyslog_server/tasks/rsyslog.yml index 4a8462d73..f4869bf09 100644 --- a/roles/rsyslog_server/tasks/rsyslog.yml +++ b/roles/rsyslog_server/tasks/rsyslog.yml @@ -93,7 +93,7 @@ src: roles/rsyslog_server/templates/rsyslog.conf dest: /etc/rsyslog.conf force: true - mode: 0644 + mode: '0644' become: true notify: restart-rsyslog.service diff --git a/roles/ssh_known_hosts/tasks/main.yml b/roles/ssh_known_hosts/tasks/main.yml index d511e463c..174fe638c 100644 --- a/roles/ssh_known_hosts/tasks/main.yml +++ b/roles/ssh_known_hosts/tasks/main.yml @@ -2,7 +2,7 @@ - name: Create /etc/ssh/ssh_known_hosts file with public key from CA that signed the host keys. ansible.builtin.copy: dest: /etc/ssh/ssh_known_hosts - mode: 0644 + mode: '0644' owner: root group: root content: "@cert-authority * {{ lookup('file', ssh_host_signer_ca_private_key + '.pub') }}" diff --git a/roles/static_hostname_lookup/tasks/main.yml b/roles/static_hostname_lookup/tasks/main.yml index 19c75c4cb..de5d65f99 100644 --- a/roles/static_hostname_lookup/tasks/main.yml +++ b/roles/static_hostname_lookup/tasks/main.yml @@ -3,7 +3,7 @@ ansible.builtin.template: src: templates/hosts.j2 dest: /etc/hosts - mode: 0644 + mode: '0644' owner: root group: root backup: true diff --git a/roles/swap/tasks/enable_swap.yml b/roles/swap/tasks/enable_swap.yml index f9700f7e1..ad912a0d0 100644 --- a/roles/swap/tasks/enable_swap.yml +++ b/roles/swap/tasks/enable_swap.yml @@ -18,7 +18,7 @@ path: "{{ swap_file_path }}" owner: root group: root - mode: 0600 + mode: '0600' become: true - name: Add swap file entry to fstab.