deleteByQuery() implemented in Elastica\Index #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
ruflin
added a commit
that referenced
this pull request
Apr 17, 2015
deleteByQuery() implemented in Elastica\Index
|
Thx |
|
@ruflin Any way you can bump the version? |
|
@tmatei Not sure what you mean. There were already 2 releases with the changes above. |
|
@ruflin sorry my bad, I was still on the 1.4.x, didn't notice you moved to 2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that
deleteByQuery()is only available atElastica\Type, for convenience I've implementedElastica\Index::deleteByQuery()and I've added the same tests thatElastica\Typehas but with a few modifications to validate that documents from all types of the index are successfully deleted.