Fix fluent interface inconsistency #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Elastica\Aggregation\AbstractAggregation::setName - Elastica\Bulk::setRequestParam - Elastica\Bulk::setShardTimeout - Elastica\Client::addHeader - Elastica\Client::removeHeader - Elastica\Connection\ConnectionPool::addConnection - Elastica\Connection\ConnectionPool::setConnections - Elastica\Filter\AbstractGeoShape::setRelation - Elastica\Query::setSuggest - Elastica\Script::setScript - Elastica\Script::setLang - Elastica\Transport\AbstractTransport::setConnection - Elastica\Type::setSerializer
1 similar comment
| * @return \Elastica\Bulk\Action\AbstractDocument | ||
| * @param \Elastica\Document|\Elastica\Script $data | ||
| * @param string $opType | ||
| * @return static |
ruflin
added a commit
that referenced
this pull request
Feb 21, 2015
Fix fluent interface inconsistency
|
Awesome. Thanks. |
|
@im-denisenko BTW: I think you will like this: https://scrutinizer-ci.com/g/ruflin/Elastica/?branch=master |
|
I quickly looked at reported issues, and yeah, it's awesome :) Though, many of them seems to be false-positive due to incorrect phpdoc comments (this tool gets variable types from docblocks, as I can guess) Speaking of that, I see 1527 warnings every time I trying to run phpdoc. I already wanted to fix that, so now there yet another reason to do this. |
|
:-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@returndocblock updated across entire library. Finishes work started in Fix IDE doc for better auto-completion #774.@paramand@returnrealigned using php-cs-fixer.