post_filter and filter are now the same #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added a commit
that referenced
this pull request
Aug 25, 2014
post_filter and filter are now the same
|
Merged. Thx. |
|
Hm, I just realised you missed to update the changes.txt file. Can you open a new pull request? Sorry about that. |
|
Sure :) |
|
@ruflin maybe we should trigger a php error (E_USER_DEPRECATED) instead of just setting phpdoc to deprecated bool trigger_error ( string $error_msg [, int $error_type = E_USER_NOTICE ] )Trigger it in Query->setFilter - this function is deprecated and will be removed in feature realeases |
|
Good idea. It's a little bit messy in the code but the good thing is it will pop up also in the tests. |
krzaczek
added a commit
to krzaczek/Elastica
that referenced
this pull request
Aug 25, 2014
krzaczek
added a commit
to krzaczek/Elastica
that referenced
this pull request
Aug 25, 2014
krzaczek
added a commit
to krzaczek/Elastica
that referenced
this pull request
Aug 25, 2014
krzaczek
added a commit
to krzaczek/Elastica
that referenced
this pull request
Aug 25, 2014
krzaczek
added a commit
to krzaczek/Elastica
that referenced
this pull request
Aug 25, 2014
krzaczek
added a commit
to krzaczek/Elastica
that referenced
this pull request
Aug 25, 2014
krzaczek
added a commit
to krzaczek/Elastica
that referenced
this pull request
Aug 25, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #669
This should work fine.
Some of the tests should probably be rewritten to use FIlteredQuery instead of Query->setPostFilter(). The results are fine ... but You should use setPostFilter only to filter results after facets/aggregations have been calculated.