Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON parsing in response sometimes gets it wrong #586

Closed
mal opened this issue Apr 17, 2014 · 0 comments · Fixed by #587
Closed

JSON parsing in response sometimes gets it wrong #586

mal opened this issue Apr 17, 2014 · 0 comments · Fixed by #587

Comments

@mal
Copy link
Contributor

mal commented Apr 17, 2014

As of 1.0 the /index/type/_mapping endpoint (for one) can return {} which is both empty() but also valid. However because it's empty() it gets treated as a string, and put into a message key by the response class, which is a bit odd and unexpected.

Relevant line: Response.php#L183

PR forthcoming 😀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only detect real JSON parsing errors idio/elastica
1 participant
@mal