GeoShape Filters #568
Merged
GeoShape Filters #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking this over. Can you make sure to merge in the master again and update the changes.txt file? If possible, please also provide some integration tests which call directly elasticsearch. So it is easy to spot, in case it is not compatible with certain ES versions. Let me know when you added it as I don't get a notifications for new commits :-( |
|
Added an entry to the changes.txt file as well as functional tests for both filters |
|
Merged. Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause the ElasticSearch GeoShape filters are awesome and the other pull request seems dead.
The GeoShape pre-indexed and provided filters, documented here.
With unit tests