Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get default values from index setting api #2114

Closed
krasilnikovm opened this issue Aug 16, 2022 · 3 comments
Closed

Get default values from index setting api #2114

krasilnikovm opened this issue Aug 16, 2022 · 3 comments

Comments

@krasilnikovm
Copy link
Contributor

krasilnikovm commented Aug 16, 2022

Problem:

I need to retrieve index settings like 'max_result_window' but in the response body default value is not returned, in order to fetch the default value need to add the include_default query param to /_setting request.

Suggestion:

We can add the ability to set flag include_default(or by default set to true?) and change the behavior of \Elastica\Index\Settings::get method

  1. search setting value in the setting key as before
  2. if the value is not found on 1 step then search setting value in default key.
@krasilnikovm
Copy link
Contributor Author

What do think about this? is it will be useful for this lib?

@krasilnikovm
Copy link
Contributor Author

I have prepared PR: #2115

@deguif
Copy link
Collaborator

deguif commented Oct 17, 2022

Closing as this merged.

@deguif deguif closed this as completed Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants