Elastica\Client\updateDocument fails with ES 7.3

[lenada]

When testing current master against Elasticsearch 7.3
->updateDocument() throws

Elasticsearch\Common\Exceptions\UnexpectedValueException

"version" is not a valid parameter. Allowed parameters are "_source", "_source_excludes", "_source_includes", "error_trace", "filter_path", "human", "if_primary_term", "if_seq_no", "lang", "opaqueId", "parent", "pretty", "refresh", "retry_on_conflict", "routing", "source", "timeout", "wait_for_active_shards"

After removing the version parameter it seems to update the document just fine.

Apart from that issue; are there plans to tag a ES 7.3 compatible release anytime soon?

[ruflin]

@lenada Thanks for filing. There are definitively plans for a 7.x release but we are currently blocked a bit on #1666

Did you dig into more details by chance on what changed in 7.3 Elasticsearch that causes the above (like a changelog)?

[lenada]

It seems the version parameter was deprecated in ES 7.0.0
Remove support for internal versioning for concurrency control
(See CRUD paragraph)

related issue: elastic/elasticsearch#38254

[philkra]

I tested ->updateDocument() with the branch es-7-remove-type from PR #1666 and reproduced the error.

[lenada]

@ruflin @thePanz I recently tested Release 7.0.0-beta.3 unfortunately ist seems the version parameter is still present there and errors with ES >= 7.0

[ruflin]

@lenada Did you figure out by chance where in the code this is coming from?

[thePanz]

@lenada @philkra can you provide an example code where the exception is being thrown?

[lenada]

@ruflin @thePanz thank you for your time! When I comment https://github.com/ruflin/Elastica/blob/master/lib/Elastica/Client.php#L365 no exception is thrown.
I wonder why this error does not occur on any travis builds?

[ruflin]

Makes me wonder if we have a test case for updateDocument :-)

[armandojs]

I can confirm this on my end as well. I'm using "ruflin/elastica": "7.0.0-beta.3"

Retrieving a document brings the 'version' parameter with it and saving the document back by running updateDocument produces the error.

I can work around this by removing the 'version' parameter from the params array though not sure if it's a good idea. My Elasticsearch/Elastica knowledge is very superficial.

[consolari]

Reproduced this on elaticsearch 7.9.1 and elatica dev-master. Everything else seems to work fine. Any chance it can be prioritized up?

When uncommented 'version' in params in Client.php->updateDocument() it works.

[ruflin]

@consolari Any chance you could open a PR with this change against master? This should simplify the dicsussion and we will also see what tests this effects.

[deguif]

Closed as it was fixed in #1803