Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for BucketSelector aggregation? #1397

Closed
george-ionita opened this issue Nov 2, 2017 · 4 comments
Closed

Missing support for BucketSelector aggregation? #1397

george-ionita opened this issue Nov 2, 2017 · 4 comments

Comments

@george-ionita
Copy link

Shouldn't there be a "BucketSelector" class in /Elastica/Aggregation?

https://www.elastic.co/guide/en/elasticsearch/reference/5.5/search-aggregations-pipeline-bucket-selector-aggregation.html

Using Elastica 5.3, ElasticSearch 5.5.

@p365labs
Copy link
Collaborator

p365labs commented Nov 2, 2017

yes you're right :) it's missing. Maybe you could do implement it and create a PR ?

@george-ionita
Copy link
Author

I needed it yesterday so I wrote it, will make a PR in a bit :)

@gontrocolo
Copy link

Hey @george-ionita , its been a year since you wrote that. Any update on this?
Thanks :)

@maltehuebner
Copy link
Contributor

I added the BucketSelector aggregation in #1554.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants