Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a configuration flag to control this setting? #107

Closed
wants to merge 1 commit into from

Conversation

maetl
Copy link

@maetl maetl commented Nov 24, 2011

This addresses #106 - not quite sure the best way to make this configurable. It would also make more sense to have this default to "true" and only switch it off if explicitly set by the user.

Here's another (admittedly very opinionated) perspective on this issue: http://www.rubyinside.com/how-to-cure-nethttps-risky-default-https-behavior-4010.html

@ruflin
Copy link
Owner

ruflin commented Nov 24, 2011

Perhaps we should create a complete array for transport options, because I'm sure more will follow. For example:

transport => arrray(
'type' => 'https',
'verifySsl' => '...'
).

To make it backward compatible, the option of only a string for transport should be allowed.

ruflin added a commit that referenced this pull request Jan 8, 2012
@ruflin
Copy link
Owner

ruflin commented Jan 8, 2012

I added to possibility to set the curl params in the config (see commit) to solve this problem.

@maetl
Copy link
Author

maetl commented Jan 15, 2012

Cool, can see exactly how it works from the diff. Thanks!

@maetl maetl closed this Jan 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants