Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(router): periodic flush during pickup #3497

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Jun 14, 2023

Description

Occasionally, router's pickup may take more than a few seconds, e.g. when it is going deep in its large backlog attempting to find jobs eligible for processing.
To avoid having long pauses and large bursts in workers, the pickup loop will now be flushing its jobs every 2 seconds.

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 88.46% and project coverage change: +0.08 🎉

Comparison is base (5021989) 68.07% compared to head (d9f74c6) 68.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3497      +/-   ##
==========================================
+ Coverage   68.07%   68.15%   +0.08%     
==========================================
  Files         330      330              
  Lines       53577    53589      +12     
==========================================
+ Hits        36473    36525      +52     
+ Misses      14713    14674      -39     
+ Partials     2391     2390       -1     
Impacted Files Coverage Δ
router/handle.go 74.50% <88.00%> (+1.29%) ⬆️
router/handle_lifecycle.go 94.40% <100.00%> (-0.98%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum merged commit 1193acc into master Jun 14, 2023
@atzoum atzoum deleted the chore.routerIterator branch June 14, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants