Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(router): observability on job iterator discards & stop iteration if throttled with destination isolation enabled #3491

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Jun 13, 2023

Description

Adding a counter for monitoring discarded jobs in router's iterator and stopping iteration in case jobs are discarded due to throttling and destination isolation is enabled

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

BEGIN_COMMIT_OVERRIDE
chore(router): observability on job iterator discards & stop iteration if throttled with destination isolation enabled #3491
END_COMMIT_OVERRIDE

@atzoum atzoum requested a review from cisse21 June 13, 2023 16:48
@atzoum atzoum changed the title chore(router): job worker observability & stop iteration if throttled chore(router): observability on job discards & stop iteration if throttled with destination isolation Jun 13, 2023
@atzoum atzoum changed the title chore(router): observability on job discards & stop iteration if throttled with destination isolation chore(router): observability on job iterator discards & stop iteration if throttled with destination isolation Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 75.75% and no project coverage change.

Comparison is base (b525949) 68.01% compared to head (20246c7) 68.01%.

❗ Current head 20246c7 differs from pull request most recent head d1eaa01. Consider uploading reports for the commit d1eaa01 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3491   +/-   ##
=======================================
  Coverage   68.01%   68.01%           
=======================================
  Files         330      330           
  Lines       53574    53591   +17     
=======================================
+ Hits        36437    36450   +13     
- Misses      14740    14745    +5     
+ Partials     2397     2396    -1     
Impacted Files Coverage Δ
router/types/types.go 91.11% <ø> (ø)
router/isolation/isolation.go 82.35% <33.33%> (-10.51%) ⬇️
router/handle.go 73.21% <85.18%> (+1.36%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum force-pushed the chore.workerSlotObservability branch from d5e7de7 to 20246c7 Compare June 14, 2023 05:38
@atzoum atzoum force-pushed the chore.workerSlotObservability branch from 20246c7 to afed61a Compare June 14, 2023 05:39
@atzoum atzoum changed the title chore(router): observability on job iterator discards & stop iteration if throttled with destination isolation chore(router): observability on job iterator discards & stop iteration if throttled with destination isolation enabled Jun 14, 2023
@atzoum atzoum merged commit 66e32ad into master Jun 14, 2023
@atzoum atzoum deleted the chore.workerSlotObservability branch June 14, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants