fix: router panics with limit for rt_pickup must be greater than 0 #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cisse21
approved these changes
Jun 8, 2023
achettyiitr
approved these changes
Jun 8, 2023
Sidddddarth
approved these changes
Jun 8, 2023
fracasula
approved these changes
Jun 8, 2023
lvrach
approved these changes
Jun 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3467 +/- ##
==========================================
- Coverage 68.53% 68.32% -0.21%
==========================================
Files 327 327
Lines 52801 52873 +72
==========================================
- Hits 36189 36128 -61
- Misses 14266 14360 +94
- Partials 2346 2385 +39
☔ View full report in Codecov by Sentry. |
Merged
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrong order of arguments while calling
getRouterConfigIntcaused issues with configurations containing destination type specific configuration overrides in router module.Notion Ticket
Link
Security