fix: migration fails with error pq: VACUUM cannot run inside a transaction block #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
requested review from
BonapartePC,
Sidddddarth,
cisse21,
lvrach and
saurav-malani
fracasula
approved these changes
Jun 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3464 +/- ##
==========================================
+ Coverage 68.51% 68.75% +0.24%
==========================================
Files 330 330
Lines 53034 53042 +8
==========================================
+ Hits 36335 36468 +133
+ Misses 14335 14205 -130
- Partials 2364 2369 +5
☔ View full report in Codecov by Sentry. |
lvrach
approved these changes
Jun 8, 2023
Sidddddarth
approved these changes
Jun 8, 2023
Merged
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue introduced by #3434, since a VACUUM command cannot be executed inside a transaction. Vacuum or vacuum full are now being executed, if necessary, after the transaction completes. Added the necessary test case to verify proper behaviour.
Notion Ticket
Link
Security