chore: cleanup for integration tests for warehouse #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3412 +/- ##
==========================================
- Coverage 68.58% 68.57% -0.01%
==========================================
Files 329 329
Lines 52778 52778
==========================================
- Hits 36196 36192 -4
- Misses 14252 14254 +2
- Partials 2330 2332 +2 ☔ View full report in Codecov by Sentry. |
cisse21
approved these changes
May 30, 2023
fracasula
approved these changes
May 30, 2023
Merged
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since cleanup is already being called from within Start of compose library, no need to call it twice.
Notion Ticket
https://www.notion.so/rudderstacks/Cleanup-for-warehouse-integration-tests-1820ba3fdc1646309b88d83ec384b5a8?pvs=4
Security