Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: getUploadsToProcess error handling #3380

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented May 23, 2023

Description

  • Error handling for getUploadToProcess.
  • More at here.

Notion Ticket

https://www.notion.so/rudderstacks/GetUploadToProcess-error-handling-04fe991f6a90426195f8a9db78fd6e08?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (9ddf745) 68.45% compared to head (eeea7b5) 68.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3380      +/-   ##
==========================================
- Coverage   68.45%   68.42%   -0.04%     
==========================================
  Files         329      329              
  Lines       52709    52709              
==========================================
- Hits        36084    36068      -16     
- Misses      14294    14305      +11     
- Partials     2331     2336       +5     
Impacted Files Coverage Δ
warehouse/errors.go 89.47% <ø> (ø)
warehouse/warehouse.go 63.58% <0.00%> (-0.76%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@fracasula fracasula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, feel free to add a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants