-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gateway flaky test #3356
Merged
Merged
fix: gateway flaky test #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
reviewed
May 18, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3356 +/- ##
==========================================
- Coverage 68.50% 68.44% -0.06%
==========================================
Files 329 329
Lines 52709 52709
==========================================
- Hits 36106 36076 -30
- Misses 14265 14298 +33
+ Partials 2338 2335 -3 ☔ View full report in Codecov by Sentry. |
cisse21
reviewed
May 19, 2023
atzoum
reviewed
May 19, 2023
lvrach
reviewed
May 19, 2023
lvrach
reviewed
May 19, 2023
lvrach
reviewed
May 19, 2023
saurav-malani
force-pushed
the
fix.gwFlakyTest
branch
from
May 22, 2023 14:26
1f331ae
to
5d00fc4
Compare
saurav-malani
force-pushed
the
fix.gwFlakyTest
branch
from
May 23, 2023 07:16
5d00fc4
to
5d7d1fb
Compare
atzoum
approved these changes
May 23, 2023
BonapartePC
approved these changes
May 23, 2023
This was referenced May 25, 2023
Merged
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing all the
endpoints
in gateway we are runningStartWebHandler(ctx)
in a separate go routine. And, then we are hitting all the endpoints subsequently. So, there is a possibility that we start hitting endpoints before all the endpoints are registered in the router. So, added a second of delay between callingStartWebHandler
and starting to hit endpoints.Notion Ticket
< Replace with Notion Link >
Security