Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gateway flaky test #3356

Merged
merged 7 commits into from
May 23, 2023
Merged

fix: gateway flaky test #3356

merged 7 commits into from
May 23, 2023

Conversation

saurav-malani
Copy link
Contributor

Description

While testing all the endpoints in gateway we are running StartWebHandler(ctx) in a separate go routine. And, then we are hitting all the endpoints subsequently. So, there is a possibility that we start hitting endpoints before all the endpoints are registered in the router. So, added a second of delay between calling StartWebHandler and starting to hit endpoints.

Notion Ticket

< Replace with Notion Link >

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

gateway/gateway_test.go Outdated Show resolved Hide resolved
@saurav-malani saurav-malani requested a review from atzoum May 19, 2023 03:50
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (2b8e34a) 68.50% compared to head (9c35628) 68.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3356      +/-   ##
==========================================
- Coverage   68.50%   68.44%   -0.06%     
==========================================
  Files         329      329              
  Lines       52709    52709              
==========================================
- Hits        36106    36076      -30     
- Misses      14265    14298      +33     
+ Partials     2338     2335       -3     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

gateway/gateway_test.go Outdated Show resolved Hide resolved
gateway/gateway_test.go Outdated Show resolved Hide resolved
gateway/gateway_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants