-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make tests required for passing #3347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achettyiitr
force-pushed
the
chore.tests-successfull
branch
from
May 17, 2023 14:56
7976c8c
to
5d4cd09
Compare
achettyiitr
changed the title
chore: make all integration tests required for passing
chore: make warehouse integration tests required for passing
May 17, 2023
achettyiitr
force-pushed
the
chore.tests-successfull
branch
from
May 17, 2023 15:21
5d4cd09
to
e0f5ef3
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3347 +/- ##
===========================================
+ Coverage 53.32% 68.73% +15.41%
===========================================
Files 329 329
Lines 52699 52699
===========================================
+ Hits 28101 36224 +8123
+ Misses 22954 14133 -8821
- Partials 1644 2342 +698 ☔ View full report in Codecov by Sentry. |
achettyiitr
force-pushed
the
chore.tests-successfull
branch
from
May 17, 2023 15:38
e0f5ef3
to
f126a25
Compare
achettyiitr
force-pushed
the
chore.tests-successfull
branch
from
May 19, 2023 10:06
f126a25
to
48c96e5
Compare
atzoum
approved these changes
May 19, 2023
achettyiitr
changed the title
chore: make warehouse integration tests required for passing
chore: make tests required for passing
May 19, 2023
saurav-malani
approved these changes
May 22, 2023
This was referenced May 25, 2023
Merged
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notion Ticket
https://www.notion.so/rudderstacks/Make-all-integration-tests-successful-fdb435547aa24dd9ad1109b752e1b2b4?pvs=4
Security