Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make tests required for passing #3347

Merged
merged 2 commits into from
May 22, 2023
Merged

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented May 17, 2023

Description

  • Added a separate job (all-tests-successful) to make sure that all the tests (unit, warehouse integration, integration) get successful
  • It's cumbersome to mark Required for a test, especially for a Matrix when the list will be ever-growing.

Notion Ticket

https://www.notion.so/rudderstacks/Make-all-integration-tests-successful-fdb435547aa24dd9ad1109b752e1b2b4?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr requested review from lvrach and atzoum May 17, 2023 14:52
@achettyiitr achettyiitr changed the title chore: make all integration tests required for passing chore: make warehouse integration tests required for passing May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +15.41 🎉

Comparison is base (6fd8552) 53.32% compared to head (8546f3b) 68.73%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3347       +/-   ##
===========================================
+ Coverage   53.32%   68.73%   +15.41%     
===========================================
  Files         329      329               
  Lines       52699    52699               
===========================================
+ Hits        28101    36224     +8123     
+ Misses      22954    14133     -8821     
- Partials     1644     2342      +698     

see 58 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@achettyiitr achettyiitr deleted the chore.tests-successfull branch May 17, 2023 16:20
@achettyiitr achettyiitr restored the chore.tests-successfull branch May 17, 2023 16:21
@achettyiitr achettyiitr reopened this May 17, 2023
@achettyiitr achettyiitr changed the title chore: make warehouse integration tests required for passing chore: make tests required for passing May 19, 2023
@atzoum atzoum requested a review from cisse21 May 22, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants