feat: introduce a ttl cache for resources #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
requested review from
fracasula,
lvrach,
mihir20,
achettyiitr and
maheshkutty
atzoum
force-pushed
the
feat.resourceCache
branch
4 times, most recently
from
c98d973
to
97f8068
Compare
fracasula
approved these changes
May 27, 2024
| r := c.resources[instanceID] | ||
| delete(c.resources, instanceID) | ||
| delete(c.checkouts, instanceID) | ||
| go c.cleanup(r) |
There was a problem hiding this comment.
Could the lack of synchronization create issues here? Wdyt?
There was a problem hiding this comment.
Using another go-routine so that the main go-routine is not blocked. At this point no one should be using the resource, thus doing async cleanup should be safe
fracasula
reviewed
May 29, 2024
atzoum
force-pushed
the
feat.resourceCache
branch
from
c4f3b44
to
fafd33c
Compare
maheshkutty
approved these changes
May 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing a new specialty cache for resources which need to be closed/cleaned-up after their expiration.
This new cache keeps track of the resources' usage and makes sure that expired resources are not cleaned up while they are still in use and cleaned up only when they are no longer needed.
Internally it uses a
cachettl.Cachewhich has been extended with anOnEvictedcallback.Resources with any of following methods can be managed by the cache and cleaned up appropriately:
Cleanup()Close()Close() errorStop()Stop() errorSecurity