-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add remoteFilePath support and create remote directory in sftp #437
Conversation
should we also automatically create folder when file is uploaded? |
Didn't get this. We are creating the remote directory/folder when file is uploaded |
@@ -138,10 +138,11 @@ func TestUpload(t *testing.T) { | |||
|
|||
mockSFTPClient := mock_sftp.NewMockClient(ctrl) | |||
mockSFTPClient.EXPECT().Create(gomock.Any()).Return(&nopWriteCloser{remoteBuf}, nil) | |||
mockSFTPClient.EXPECT().MkdirAll(gomock.Any()).Return(nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be better if instead of using gomock.Any()
actual value that is expected for the fn is used? i.e someRemotePath
Similarly for other mocks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make any difference? Used Any() to increase the readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using actual expected value, is better for testing point of view.
Description
Linear Ticket
Resolved INT-2048
https://linear.app/rudderstack/issue/INT-2048/go-kit-create-remote-directory-in-sftp
Security