We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are certain places in the code where the view models are used as entities. For example,
webui/src/lib/infrastructure/data/view-model/page-did.d.ts
Lines 14 to 33 in 3932395
All of the data structures in the file above are entities and not view models. They should therefore be ported to lib.core.entity module.
lib.core.entity
There could be other instances of this, @ThePhisch will know ;)
For now, I will generate new API components using the entities declared in viewmodels, so that it is easier to refactor everything altogether
No response
The text was updated successfully, but these errors were encountered:
@MytsV same as #297 , it will not be affected by us changing/upgrading frameworks
Sorry, something went wrong.
Seems like this has already been done in this commit 54eafde
MytsV
Successfully merging a pull request may close this issue.
Description
There are certain places in the code where the view models are used as entities. For example,
webui/src/lib/infrastructure/data/view-model/page-did.d.ts
Lines 14 to 33 in 3932395
All of the data structures in the file above are entities and not view models. They should therefore be ported to
lib.core.entity
module.There could be other instances of this, @ThePhisch will know ;)
For now, I will generate new API components using the entities declared in viewmodels, so that it is easier to refactor everything altogether
Steps to reproduce
No response
Rucio WebUI Version
No response
Additional Information
No response
The text was updated successfully, but these errors were encountered: