Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move incorrect viewmodels to entity #320

Closed
maany opened this issue Sep 12, 2023 · 2 comments · Fixed by #460
Closed

move incorrect viewmodels to entity #320

maany opened this issue Sep 12, 2023 · 2 comments · Fixed by #460
Assignees
Labels
bug Something isn't working
Milestone

Comments

@maany
Copy link
Member

maany commented Sep 12, 2023

Description

There are certain places in the code where the view models are used as entities. For example,

export type FilereplicaStateD = {
scope: string,
name: string,
available: number,
unavailable: number,
copying: number,
being_deleted: number,
bad: number,
temporary_unavailable: number,
}
export type DIDDatasetReplicas = {
rse: string;
rseblocked: RSEBlockState;
availability: boolean;
available_files: number;
available_bytes: number;
creation_date: DateISO;
last_accessed: DateISO;
}

All of the data structures in the file above are entities and not view models. They should therefore be ported to lib.core.entity module.

There could be other instances of this, @ThePhisch will know ;)

For now, I will generate new API components using the entities declared in viewmodels, so that it is easier to refactor everything altogether

Steps to reproduce

No response

Rucio WebUI Version

No response

Additional Information

No response

@maany maany added the bug Something isn't working label Sep 12, 2023
@maany maany added this to the 33.0 milestone Sep 12, 2023
@maany maany assigned maany and unassigned ThePhisch Apr 5, 2024
@maany maany modified the milestones: 33.0, 35.0 Apr 5, 2024
@maany maany assigned MytsV and unassigned maany Aug 1, 2024
@maany maany modified the milestones: 35.0, 35.1.0, 35.2.0 Aug 13, 2024
@maany
Copy link
Member Author

maany commented Aug 13, 2024

@MytsV same as #297 , it will not be affected by us changing/upgrading frameworks

@MytsV
Copy link
Contributor

MytsV commented Aug 15, 2024

Seems like this has already been done in this commit 54eafde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants