This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Fix highlighting of method parameters. Add support for multiline parameters. #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #664 +/- ##
======================================
Coverage 5.08% 5.08%
======================================
Files 10 10
Lines 118 118
Branches 20 20
======================================
Hits 6 6
Misses 112 112
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Are there tests that could help with this for the future? |
graceful-potato
force-pushed
the
iss663
branch
from
cfee653 to
22c964e
Compare
|
Created file methods.rb with tests |
graceful-potato
force-pushed
the
iss663
branch
2 times, most recently
from
a25c8e6 to
15fb20d
Compare
feat: add support for multiline arguments feat: add double splat operator test: add tests
graceful-potato
force-pushed
the
iss663
branch
from
15fb20d to
2d66c5e
Compare
wingrunr21
approved these changes
Oct 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #663
Before
After
No more leaking scopes
Also added double splat operator.