Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Only lint on save #308

Closed
garyking opened this issue Mar 27, 2018 · 7 comments
Closed

Only lint on save #308

garyking opened this issue Mar 27, 2018 · 7 comments
Assignees
Labels
Milestone

Comments

@garyking
Copy link

Is it possible to make it so that this extension only lints on save, so that we don't errors while still writing code? Like the warning for unused variables?

@gurgeous
Copy link
Contributor

gurgeous commented Apr 2, 2018

Good idea, though personally I think this is beyond the scope of our extension. Even much more advanced linters (like vscode eslint) don't support this option. If our linter worked great you probably wouldn't want this feature anyway :)

@wingrunr21
Copy link
Collaborator

This can be supported similar to how TSLint supports it (see microsoft/vscode-tslint#68).

Adding to v1 milestone

@wingrunr21 wingrunr21 added this to the 1.0.0 milestone Apr 4, 2018
@wingrunr21 wingrunr21 self-assigned this Apr 4, 2018
@garyking
Copy link
Author

garyking commented Apr 9, 2018

VSCode ESLint does actually support this option, with "eslint.run": "onSave",.

@gurgeous
Copy link
Contributor

gurgeous commented Apr 9, 2018

Whoops. This public shaming is working - maybe I'll submit a PR. :) I've been meaning to dig into this more to examine other issues like #238, #262 and #307. Only if you aren't working on it, @wingrunr21. I see you assigned this to yourself...

@wingrunr21
Copy link
Collaborator

If you want to PR against the current codebase go ahead. I'm planning on mirroring the eslint/tslint support on the language server side.

@gurgeous gurgeous mentioned this issue Apr 10, 2018
6 tasks
@andrewmcodes
Copy link

Is this still an issue using 0.20.0?

@github-actions
Copy link

This issue has not had activity for 30 days. It will be automatically closed in 7 days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants