Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Linters and vim mode(s) don't get along #252

Closed
onyxraven opened this issue Jan 26, 2018 · 9 comments
Closed

Linters and vim mode(s) don't get along #252

onyxraven opened this issue Jan 26, 2018 · 9 comments

Comments

@onyxraven
Copy link

onyxraven commented Jan 26, 2018

Your environment

  • vscode-ruby version: 0.16.0 (and 0.15.0 it turns out)
  • Ruby version: 2.4.3
  • VS Code version: Version 1.19.3 (1.19.3)
  • Operating System: OSX 10.13.3 (17D47)
  • Hardware (optional): MacBook Pro (Retina, 15-inch, Mid 2014)

Make sure you have ruby, ruby-debug-ide and ruby-debug-basex19 installed before submitting your issue -- thank you !

Expected behavior

When using Vim or amVim extensions along with Ruby linters enabled, typing should not be delayed every character for lints to complete.

Actual behavior

It seems like for every linter enabled, they are running on the main input thread and blocking the inputs. This looks to even get in between the keypress and the autocomplete/suggestions.

Steps to reproduce the problem

It seems like using either of those extensions, along with any enabled linters (which arguably do hook all editor inputs for modes) cause the issue to show very obviously. Editing other file types with the extensions is not a problem. Disabling all linters makes inputs work again without delay.


I'm happy to help with more investigation, but I just need some guidance on where to look next.

@onyxraven
Copy link
Author

I just downgraded to 0.15 (using the helpful link in a different issue) and it seems to be still happening in the same way. So I'm thinking it has something to do with the 1.19.3 update. I'll check the issue board for the main VSCode project to see if there is anything related.

@castwide
Copy link
Contributor

I don't use Vim or amVim, but I had a similar problem. I got the best performance (short of no linters at all) using RuboCop alone with the latest gem.

@MythicalFish
Copy link

Same issue here, can confirm that disabling the linters solves the lag.

@wingrunr21
Copy link
Collaborator

Can some of you post your linter configs?

I also don't see this issue using VIM + Rubocop. I'm wondering if the changes made in #232 might be affecting something there (although linter performance wasn't great before that either).

@cyangOL
Copy link

cyangOL commented Jan 31, 2018

I have the same issue. Typing is noticeably slow when vim and ruby are the only enabled plugin.

@onyxraven
Copy link
Author

in 1.6.0 I was able to reproduce with the following config

    "ruby.lint": {
        "rubocop": false,
        "ruby": true, //Runs ruby -wc
        "fasterer": false,
        "debride": false,
        "ruby-lint": false
    },

ruby -wc is fastish but it still would delay typing input.

I downgraded to 1.5 and the delay has seemed to go away this time. I'm still using the Vim plugin. I'll see if I can gather any other situational info

@MythicalFish
Copy link

Any updates on this? Would be nice to reenable linters. :)

@doudou
Copy link
Contributor

doudou commented Mar 12, 2018

The debouncing in #264 solved the issue for me.

@onyxraven
Copy link
Author

Master is fixed with the changes in #264

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants