From 42ec0633c7353f0d7a5e38729ee61736fe945dd1 Mon Sep 17 00:00:00 2001 From: Koichi ITO Date: Thu, 31 Aug 2017 19:26:48 +0900 Subject: [PATCH 1/3] Suppress `warning: URI.unescape is obsolete` --- lib/gemstash/upstream.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/gemstash/upstream.rb b/lib/gemstash/upstream.rb index 839ca7e6..d7af28b7 100644 --- a/lib/gemstash/upstream.rb +++ b/lib/gemstash/upstream.rb @@ -11,7 +11,7 @@ class Upstream def_delegators :@uri, :scheme, :host, :user, :password, :to_s def initialize(upstream, user_agent: nil) - @uri = URI(URI.decode(upstream.to_s)) + @uri = URI(CGI.unescape(upstream.to_s)) @user_agent = user_agent raise "URL '#{@uri}' is not valid!" unless @uri.to_s =~ URI.regexp end From b60f44e0db7cc95e709355d97fae936da11e6af9 Mon Sep 17 00:00:00 2001 From: Koichi ITO Date: Thu, 31 Aug 2017 19:25:06 +0900 Subject: [PATCH 2/3] Suppress `warning: URI.regexp is obsolete` --- lib/gemstash/upstream.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/gemstash/upstream.rb b/lib/gemstash/upstream.rb index d7af28b7..698aee92 100644 --- a/lib/gemstash/upstream.rb +++ b/lib/gemstash/upstream.rb @@ -13,7 +13,7 @@ class Upstream def initialize(upstream, user_agent: nil) @uri = URI(CGI.unescape(upstream.to_s)) @user_agent = user_agent - raise "URL '#{@uri}' is not valid!" unless @uri.to_s =~ URI.regexp + raise "URL '#{@uri}' is not valid!" unless @uri.to_s =~ URI::DEFAULT_PARSER.make_regexp end def url(path = nil, params = nil) From 827a3a86a250ff44aeb46ecee58e91ee40bde7a9 Mon Sep 17 00:00:00 2001 From: Koichi ITO Date: Thu, 31 Aug 2017 19:32:13 +0900 Subject: [PATCH 3/3] Suppress `warning: instance variable @properties not initialized` --- lib/gemstash/storage.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/gemstash/storage.rb b/lib/gemstash/storage.rb index 3a015b53..cc24b831 100644 --- a/lib/gemstash/storage.rb +++ b/lib/gemstash/storage.rb @@ -117,6 +117,7 @@ def initialize(folder, name) digest = Digest::MD5.hexdigest(@name) child_folder = "#{safe_name}-#{digest}" @folder = File.join(@base_path, *trie_parents, child_folder) + @properties = nil end # When +key+ is nil, this will test if this resource exists with any