-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a louder error for on /requesters/new if phone field isn't formatted correctly #306
Comments
Same is for email |
I would like to try and work on this, but I'm stuck because I don't have any log in credentials. What's the default way to log in locally for testing purposes? There must be something obvious that I'm missing.. 😅 Also, what exactly do you mean by "louder error"? Do you mean on the form as direct user feedback, or in the backend tests? |
@laser-shark As described here https://docs.dev.to/backend/authentication/ you need to log in with Github or Twitter And as for louder error - it's for user feedback - currently there's no visible validation message about required format in the app and user won't know why the submit button doesn't do anything - I only saw 422 in the logs. So basically, you need to pass the Rails validation error to the user interface via JS. Also, same happens for invalid email. The only validation visible is if some required fields are not filled in. |
@laser-shark the development login account info is available in and, thanks @matisnape for the help! |
@matisnape i added a new issue re the same thing w email (and also w county if it's blank) |
@laser-shark just assigned this one to you. lmk if you are able to log in. thank you for your help! |
@maebeale Thanks for the hint, I was able to log in now! I will start working on this now and hopefully be done in a few days. |
@laser-shark hello there! are you still planning to work on this? |
ddd-ddd-dddd
formatThe text was updated successfully, but these errors were encountered: