Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a louder error for on /requesters/new if phone field isn't formatted correctly #306

Open
maebeale opened this issue Oct 12, 2019 · 8 comments

Comments

@maebeale
Copy link
Collaborator

  • Right now it's a silent error if you've added something to the field, but it doesn't have the ddd-ddd-dddd format
@matisnape
Copy link
Contributor

Same is for email

@laser-shark
Copy link
Contributor

I would like to try and work on this, but I'm stuck because I don't have any log in credentials. What's the default way to log in locally for testing purposes? There must be something obvious that I'm missing.. 😅

Also, what exactly do you mean by "louder error"? Do you mean on the form as direct user feedback, or in the backend tests?

@matisnape
Copy link
Contributor

matisnape commented Oct 13, 2019

@laser-shark As described here https://docs.dev.to/backend/authentication/ you need to log in with Github or Twitter

And as for louder error - it's for user feedback - currently there's no visible validation message about required format in the app and user won't know why the submit button doesn't do anything - I only saw 422 in the logs. So basically, you need to pass the Rails validation error to the user interface via JS.

Also, same happens for invalid email. The only validation visible is if some required fields are not filled in.

@maebeale
Copy link
Collaborator Author

maebeale commented Oct 14, 2019

@laser-shark the development login account info is available in seeds.rb

and, thanks @matisnape for the help!

@maebeale
Copy link
Collaborator Author

@matisnape i added a new issue re the same thing w email (and also w county if it's blank)

@maebeale
Copy link
Collaborator Author

@laser-shark just assigned this one to you. lmk if you are able to log in. thank you for your help!
p.s. i'm going to add a new issue for someone to update the readme re finding the login credentials. that is a gotcha, so appreciate your bringing it up.

@laser-shark
Copy link
Contributor

@maebeale Thanks for the hint, I was able to log in now! I will start working on this now and hopefully be done in a few days.

@maebeale
Copy link
Collaborator Author

@laser-shark hello there! are you still planning to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants