Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/announcements breaks if any announcement has no description #888

Closed
solebared opened this issue Mar 3, 2021 · 3 comments · Fixed by #904
Closed

/announcements breaks if any announcement has no description #888

solebared opened this issue Mar 3, 2021 · 3 comments · Fixed by #904
Labels

Comments

@solebared
Copy link
Collaborator

solebared commented Mar 3, 2021

Steps to recreate:

  1. Create an announcement w/o a description
  2. Go to /announcements

Probably worth checking other Announcement pages and the landing page as well.

@solebared solebared added Type: Bug Something isn't working beginner friendly Good First Issue Good for newcomers help wanted labels Mar 3, 2021
@samudary
Copy link
Collaborator

Hi @exbinary or @maebeale I'm thinking of picking this up but wanted some clarification on requirements. I tried creating an announcement both as an admin and unauthed but there's a UI validation that prevents submitting without a description. There's also a model validation should safeguard against this as well. So I'm not sure how to reproduce the issue

@maebeale
Copy link
Collaborator

@samudary hey! thanks for following up on this, and, excellent point! this error happens when we upgrade existing instances to the new requirements. they had announcements in the database when this wasn't a restriction.

there are three ways to create underlying data to produce the error. i think the first one is the only that could possibly be supported in tests:

  • use a SQL insert statement either in the console or using psql
  • remove the model validation temporarily, restart console and create there
  • remove the UI AND model validation temporarily, restart console and create there

@samudary
Copy link
Collaborator

Got it! That context is helpful, thanks. I'll get a PR going

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants