Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange Navbar links to decide Contributions positioning #826

Closed
Tracked by #1001
svileshina opened this issue Jan 18, 2021 · 0 comments
Closed
Tracked by #1001

Rearrange Navbar links to decide Contributions positioning #826

svileshina opened this issue Jan 18, 2021 · 0 comments

Comments

@svileshina
Copy link
Collaborator

svileshina commented Jan 18, 2021

PR #821 added Contributions button to the navbar when user is in p2p but logged out:

And then it prompted a conversation about the rearranging of this (and other) buttons in the navbar to denote priority without causing confusion when buttons change locations based on mode/logged in status. The following is from discussions from the PR:

We talked some about rearranging these. Our concerns were:

arranging buttons so items of higher priority or higher usefulness stand out more, which changes depending on context
if someone logged in trying is to give instruction to someone not logged, it should be easy without the logged in person having to memorize which buttons are and are not the same for the logged out person
having order be consistent and predictable
understanding that most logged in users won't be spending much time if any looking at what a not logged in person sees
Because of all these concerns, we agreed to revisit how to balance them later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants