From f992ac60b91d30affa45f6b29d412f46e9120c0d Mon Sep 17 00:00:00 2001 From: Herwin Date: Sun, 13 Oct 2024 18:49:15 +0200 Subject: [PATCH 1/3] Remove Gemfile, add script for Rubocop --- .github/workflows/ci.yml | 3 +-- Gemfile | 3 --- bin/rubocop | 12 ++++++++++++ 3 files changed, 13 insertions(+), 5 deletions(-) delete mode 100644 Gemfile create mode 100755 bin/rubocop diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 493ce193e..6bc11b21d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -72,5 +72,4 @@ jobs: - uses: ruby/setup-ruby@v1 with: ruby-version: '3.0' - - run: bundle install - - run: bundle exec rubocop --parallel + - run: bin/rubocop diff --git a/Gemfile b/Gemfile deleted file mode 100644 index ef29689db..000000000 --- a/Gemfile +++ /dev/null @@ -1,3 +0,0 @@ -source 'https://rubygems.org' - -gem 'rubocop', '= 1.66.1' diff --git a/bin/rubocop b/bin/rubocop new file mode 100755 index 000000000..7b9a9b119 --- /dev/null +++ b/bin/rubocop @@ -0,0 +1,12 @@ +#!/usr/bin/env ruby +# frozen_string_literal: true + +require 'bundler/inline' + +gemfile do + source 'https://rubygems.org' + + gem 'rubocop', '= 1.66.1' +end + +exec(Gem.bin_path('rubocop', 'rubocop'), *ARGV) From 7c3dcd033d1d1b05e0e9909525e705eb438bcf6b Mon Sep 17 00:00:00 2001 From: Herwin Date: Sun, 13 Oct 2024 18:52:59 +0200 Subject: [PATCH 2/3] Switch to more recent Ruby version to run Rubocop --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6bc11b21d..f4000964d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -71,5 +71,5 @@ jobs: - uses: actions/checkout@v4 - uses: ruby/setup-ruby@v1 with: - ruby-version: '3.0' + ruby-version: '3.3' - run: bin/rubocop From e648284e694de9d0d6a6666b76e16deee0c30eab Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Mon, 14 Oct 2024 19:38:42 +0200 Subject: [PATCH 3/3] Simplify version requirement in bin/rubocop --- bin/rubocop | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/rubocop b/bin/rubocop index 7b9a9b119..38254f13e 100755 --- a/bin/rubocop +++ b/bin/rubocop @@ -6,7 +6,7 @@ require 'bundler/inline' gemfile do source 'https://rubygems.org' - gem 'rubocop', '= 1.66.1' + gem 'rubocop', '1.66.1' end exec(Gem.bin_path('rubocop', 'rubocop'), *ARGV)