-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra rubocop offenses when running rubocop on ruby/spec #2539
Comments
Something very odd is happening with |
I'm not sure if this is the right place to be tracking these, so apologies if that's the case, but I also found that the following cops were being triggered incorrectly when using implicit keyword values: # Lint/UnusedMethodArgument
def foo(bar)
Baz.new(bar:)
end # Lint/UnusedBlockArgument
[1, 2, 3].each do |n|
Foo.new(n:)
end That said, it found these (incorrect) issues very quickly, so, nice work :D |
Here's a minimal example that results in a false positive for # 👎
<<-RUBY.squish
a
b
RUBY |
Just as a note, the multibyte stuff in this issue has been fixed, but the implicit string concat thing hasn't. |
I have got a similar issue with Japanese/Asian characters and a very specific file layout. File:class FooController
def create
flash[:alert] = "更新に失敗しました。"
Notifier.new.notify(msg: "問診でエラーが起こりました。")
end
def questionnaire_reply(new = false)
{
emojis: [
],
text: "
問診の#{new ? '回答' : '更新'}ありがとうございました$
"
}
end
end Note:
|
From rubocop/rubocop#12724 (comment)
I noticed there are 3 more offenses when running with
ParserEngine: parser_prism
:I guess there are due to some differences between parser gem and
Prism::Translation::Parser
.The text was updated successfully, but these errors were encountered: