Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Ruby 3.0 support? #915

Closed
godfat opened this issue Jan 2, 2024 · 2 comments
Closed

Restore Ruby 3.0 support? #915

godfat opened this issue Jan 2, 2024 · 2 comments

Comments

@godfat
Copy link
Contributor

godfat commented Jan 2, 2024

GitLab attempted to upgrade grape-swagger from 1.6.1 to 2.0.0, however GitLab has to revert it because 2.0.0 doesn't support Ruby 3.0: https://gitlab.com/gitlab-org/quality/engineering-productivity/master-broken-incidents/-/issues/4841#note_1710824588

I noticed this was dropped at 8e723c6

And I see the reasoning was:

  • Aligns ruby and grape version with test matrix.

Which makes sense to me. However, I would like to ask if it's possible to at least restore support for Ruby 3.0 if it's actually working. I tried to run tests locally with Ruby 3.0 and everything passed.
@godfat godfat mentioned this issue Jan 2, 2024
Merged
@godfat
Copy link
Contributor Author

godfat commented Jan 2, 2024

I created a pull request for consideration: #916

@LeFnord
Copy link
Member

LeFnord commented Jan 2, 2024

closed via #916

and released as 2.0.1

@LeFnord LeFnord closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@godfat @LeFnord